[PATCH] t/httpd-unix.t: avoid race in between bind() and listen()

[PATCH] t/httpd-unix.t: avoid race in between bind() and listen()

[Eric Wong]

We need to be able to successfully connect() to the socket
before attempting further tests.  Merely testing for the
existence of a socket isn't enough, since the server may've
only done bind(), not listen().
---
 t/httpd-unix.t | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/t/httpd-unix.t b/t/httpd-unix.t
index db652479..4fe2d1eb 100644
--- a/t/httpd-unix.t
+++ b/t/httpd-unix.t
@@ -42,8 +42,9 @@ my $spawn_httpd = sub {
 
 ok(!-S $unix, 'UNIX socket does not exist, yet');
 $spawn_httpd->("-l$unix");
+my %o = (Peer => $unix, Type => SOCK_STREAM);
 for (1..1000) {
-	last if -S $unix;
+	last if -S $unix && IO::Socket::UNIX->new(%o);
 	select undef, undef, undef, 0.02
 }
 
-- 
EW