user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] ds: rely on refcounting to close descriptors
@ 2019-06-30  4:12 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-06-30  4:12 UTC (permalink / raw)
  To: meta

Since we have EPOLL_CTL_DEL implemented for the poll(2) and
kqueue backends, we can rely on Perl refcounting to gently
close(2) the underlying file descriptors as references get

This may be beneficial in the future if we want to drop a
descriptor from the event loop without actually closing it.
 lib/PublicInbox/ | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index a823602..57c4206 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -259,17 +259,8 @@ sub PostEventLoop {
     # now we can close sockets that wanted to close during our event processing.
     # (we didn't want to close them during the loop, as we didn't want fd numbers
     #  being reused and confused during the event loop)
-    while (my $sock = shift @ToClose) {
-        my $fd = fileno($sock);
-        # close the socket. (not a PublicInbox::DS close)
-        CORE::close($sock);
-        # and now we can finally remove the fd from the map.  see
-        # comment above in ->close.
-        delete $DescriptorMap{$fd};
-    }
+    delete($DescriptorMap{fileno($_)}) for @ToClose;
+    @ToClose = (); # let refcounting drop everything all at once
     # by default we keep running, unless a postloop callback (either per-object
     # or global) cancels it

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-06-30  4:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-30  4:12 [PATCH] ds: rely on refcounting to close descriptors Eric Wong

Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).