From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id A850B1F87F for ; Sat, 15 Jun 2019 08:47:16 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 02/20] v2writable: update comments regarding xcpdb --reshard Date: Sat, 15 Jun 2019 08:46:58 +0000 Message-Id: <20190615084716.3075-3-e@80x24.org> In-Reply-To: <20190615084716.3075-1-e@80x24.org> References: <20190615084716.3075-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Using compact to change shard count was abandoned during the v2 development phase. --- lib/PublicInbox/V2Writable.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm index 76e61e8..db905f9 100644 --- a/lib/PublicInbox/V2Writable.pm +++ b/lib/PublicInbox/V2Writable.pm @@ -58,8 +58,8 @@ sub count_partitions ($) { my $xpfx = $self->{xpfx}; # always load existing partitions in case core count changes: - # Also, partition count may change while -watch is running - # due to -compact + # Also, shard count may change while -watch is running + # due to "xcpdb --reshard" if (-d $xpfx) { foreach my $part (<$xpfx/*>) { -d $part && $part =~ m!/[0-9]+\z! or next; @@ -288,7 +288,7 @@ sub idx_init { $self->lock_acquire unless ($opt && $opt->{-skip_lock}); $over->create; - # -compact can change partition count while -watch is idle + # xcpdb can change shard count while -watch is idle my $nparts = count_partitions($self); if ($nparts && $nparts != $self->{partitions}) { $self->{partitions} = $nparts; -- EW