From: Eric Wong <e@80x24.org>
To: Ali Alnubani <alialnu@mellanox.com>
Cc: meta@public-inbox.org
Subject: Re: [RFC] searchview: don't be too verbose about bad queries
Date: Wed, 12 Jun 2019 17:18:28 +0000 [thread overview]
Message-ID: <20190612171828.b6xvwol57hw3e4ri@dcvr> (raw)
In-Reply-To: <AM4PR0501MB2161859AE4E8D78E74CB2585D7EC0@AM4PR0501MB2161.eurprd05.prod.outlook.com>
Ali Alnubani <alialnu@mellanox.com> wrote:
> > -----Original Message-----
> > From: Eric Wong <e@80x24.org>
> > Sent: Tuesday, June 11, 2019 10:38 PM
> > To: meta@public-inbox.org
> > Cc: Ali Alnubani <alialnu@mellanox.com>
> > Subject: [RFC] searchview: don't be too verbose about bad queries
> >
> > Ali sent this privately to me as a potential security issue.
> > I am not a security expert and I certainly don't consider this a big enough
> > problem to discuss privately...
> >
> > The potential issue is exposing path names of Xapian installs.
> >
> > I figure installation paths of open source software (particularly with FHS / LSB
> > systems) is well-standardized to the point that it's pointless to obscure or
> > obfuscate anyways.
> They are standardized for system-wide installations. But having perl libs/modules/binaries
> installed per user or on non-default paths could expose some private info, including usernames
> for example, making those system users subject to some attacks.
Fair point.
Maybe a reverse-mapping of %INC can be used to translate the
full path to the short path name (e.g. "Xapian/Enquire.pm")
Something like the following (totally untested):
# global
my %rmap_inc = map { "$INC{$_}" => $_ } keys %INC;
# in err_txt:
$err =~ s!\b(\S+)\b!
my $full = $1;
if (-e $full) {
my $short = $rmap_inc{$full};
unless (defined $short) {
# rebuild rmap in case new modules were loaded
%rmap_inc = map { "$INC{$_}" => $_ } keys %INC;
}
# fall back to basename as last resort
$short = $rmap_inc{$full} // ((split('/', $full))[-1];
} else {
$full;
}
!sge;
next prev parent reply other threads:[~2019-06-12 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 19:38 [RFC] searchview: don't be too verbose about bad queries Eric Wong
2019-06-12 8:36 ` Ali Alnubani
2019-06-12 17:18 ` Eric Wong [this message]
2019-06-25 6:37 ` [PATCH] searchview: avoid displaying full paths on errors Eric Wong
2019-06-25 7:33 ` Ali Alnubani
2019-06-26 6:35 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612171828.b6xvwol57hw3e4ri@dcvr \
--to=e@80x24.org \
--cc=alialnu@mellanox.com \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).