user/dev discussion of public-inbox itself
 help / color / Atom feed
* --reindex buggy wrt NNTP numbers, fixes coming
@ 2019-05-25 19:57 Eric Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2019-05-25 19:57 UTC (permalink / raw)
  To: meta

I was doing some cleanups and adding progress reporting to
V2Writable for public-inbox-index when I noticed NNTP article
numbers were off (too high, gaps)

And the v1 index_sync path seems buggy in this regard, too.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/3] t/v1reindex.t: fix typo in setting `indexlevel'
  2019-05-27 18:45 [PATCH 0/3] fix --reindex skipping NNTP article numbers Eric Wong
@ 2019-05-27 18:45 ` Eric Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2019-05-27 18:45 UTC (permalink / raw)
  To: meta

It did not cause a test failure because the default fallback
is `indexlevel=full'
---
 t/v1reindex.t | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/v1reindex.t b/t/v1reindex.t
index 402ecd7..35275fb 100644
--- a/t/v1reindex.t
+++ b/t/v1reindex.t
@@ -223,7 +223,7 @@ ok(!-d $xap, 'Xapian directories removed again');
 	my @warn;
 	local $SIG{__WARN__} = sub { push @warn, @_ };
 	my %config = %$ibx_config;
-	$config{indexleve} = 'medium';
+	$config{indexlevel} = 'medium';
 	my $ibx = PublicInbox::Inbox->new(\%config);
 	my $rw = PublicInbox::SearchIdx->new($ibx, 1);
 	eval { $rw->index_sync };
-- 
EW


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-27 18:45 [PATCH 0/3] fix --reindex skipping NNTP article numbers Eric Wong
2019-05-27 18:45 ` [PATCH 1/3] t/v1reindex.t: fix typo in setting `indexlevel' Eric Wong
  -- strict thread matches above, loose matches on Subject: below --
2019-05-25 19:57 --reindex buggy wrt NNTP numbers, fixes coming Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox