* [PATCH] search: don't log all warnings on retry_reopen
@ 2019-05-24 1:12 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-05-24 1:12 UTC (permalink / raw)
To: meta
Some users (or bots :P) can trigger horrible queries which
the caller can choose to either log or ignore. This prevents
horrible queries from ExtMsg from logging confusing "ref: "
messages when $@ is not a Perl reference.
---
lib/PublicInbox/Search.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index d861cf4..c054a87 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -228,7 +228,9 @@ sub retry_reopen {
warn "reopen try #$i on $@\n";
reopen($self);
} else {
- warn "ref: ", ref($@), "\n";
+ # let caller decide how to spew, because ExtMsg queries
+ # get wonky and trigger:
+ # "something terrible happened at .../Xapian/Enquire.pm"
die;
}
}
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-05-24 1:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-24 1:12 [PATCH] search: don't log all warnings on retry_reopen Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).