user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] git: calculate modified time of repository
Date: Wed, 17 Apr 2019 11:39:46 +0000	[thread overview]
Message-ID: <20190417113946.2363-1-e@80x24.org> (raw)

This will be used for generating an HTML listing for v1 inboxes,
at least.  The logic for this follows that of grokmirror,
and we may dynamically generate manifest.js.gz natively...
---
 lib/PublicInbox/Git.pm | 18 ++++++++++++++++++
 t/git.fast-import-data |  2 +-
 t/git.t                |  5 +++++
 3 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 8a96e10..236f70c 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -312,6 +312,24 @@ ($$)
 	($$buf =~ /\r?\n\r?\n([^\r\n]+)\r?\n?/)[0]
 }
 
+# returns the modified time of a git repo, same as the "modified" field
+# of a grokmirror manifest
+sub modified ($) {
+	my ($self) = @_;
+	my $modified = 0;
+	my $fh = popen($self, qw(rev-parse --branches));
+	defined $fh or return $modified;
+	local $/ = "\n";
+	foreach my $oid (<$fh>) {
+		chomp $oid;
+		my $buf = cat_file($self, $oid) or next;
+		$$buf =~ /^committer .*?> (\d+) [\+\-]?\d+/sm or next;
+		my $cmt_time = $1;
+		$modified = $cmt_time if $cmt_time > $modified;
+	}
+	$modified || time;
+}
+
 1;
 __END__
 =pod
diff --git a/t/git.fast-import-data b/t/git.fast-import-data
index 4a105ee..6d5159d 100644
--- a/t/git.fast-import-data
+++ b/t/git.fast-import-data
@@ -90,7 +90,7 @@ data 78
 commit refs/heads/master
 mark :13
 author AU Thor <e@example.com> 0 +0000
-committer AU Thor <e@example.com> 0 +0000
+committer AU Thor <e@example.com> 749520000 +0000
 data 18
 add git submodule
 from :11
diff --git a/t/git.t b/t/git.t
index d637e63..5b612b8 100644
--- a/t/git.t
+++ b/t/git.t
@@ -23,6 +23,7 @@ use_ok 'PublicInbox::Git';
 
 {
 	my $gcf = PublicInbox::Git->new($dir);
+	is($gcf->modified, 749520000, 'modified time detected from commit');
 	my $f = 'HEAD:foo.txt';
 	my @x = $gcf->check($f);
 	is(scalar @x, 3, 'returned 3 element array for existing file');
@@ -146,6 +147,10 @@ if ('alternates reloaded') {
 	ok($gcf->cleanup(time - 30), 'cleanup did not expire');
 	ok(!$gcf->cleanup(time + 30), 'cleanup can expire');
 	ok(!$gcf->cleanup, 'cleanup idempotent');
+
+	my $t = $gcf->modified;
+	ok($t <= time, 'repo not modified in the future');
+	isnt($t, 0, 'repo not modified in 1970')
 }
 
 use_ok 'PublicInbox::Git', qw(git_unquote git_quote);
-- 
EW


                 reply	other threads:[~2019-04-17 11:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190417113946.2363-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).