user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] config: ignore missing config files
@ 2019-03-08 22:54 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-03-08 22:54 UTC (permalink / raw)
  To: meta

There's no reason for us to have git-config(1) warn users when a
config file is entirely missing.
---
 lib/PublicInbox/Config.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index da443e5..2ff266f 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -147,6 +147,7 @@ sub default_file {
 sub git_config_dump {
 	my ($file) = @_;
 	my (%section_seen, @section_order);
+	return {} unless -e $file;
 	my @cmd = (qw/git config/, "--file=$file", '-l');
 	my $cmd = join(' ', @cmd);
 	my $fh = popen_rd(\@cmd) or die "popen_rd failed for $file: $!\n";
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-08 22:54 [PATCH] config: ignore missing config files Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox