user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH 1/2] t/perf-msgview: don't warn about --unordered if skipping
@ 2019-02-07 21:38 Eric Wong
  2019-02-07 21:38 ` [PATCH 2/2] t/perf-msgview.t: fix broken performance test Eric Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2019-02-07 21:38 UTC (permalink / raw)
  To: meta

No point in making noise about something that isn't used.
---
 t/perf-msgview.t | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/t/perf-msgview.t b/t/perf-msgview.t
index adeb7aa..4975305 100644
--- a/t/perf-msgview.t
+++ b/t/perf-msgview.t
@@ -8,6 +8,9 @@ use PublicInbox::Inbox;
 use PublicInbox::View;
 require './t/common.perl';
 
+my $pi_dir = $ENV{GIANT_PI_DIR};
+plan skip_all => "GIANT_PI_DIR not defined for $0" unless $pi_dir;
+
 my @cat = qw(cat-file --buffer --batch-check --batch-all-objects);
 if (require_git(2.19, 1)) {
 	push @cat, '--unordered';
@@ -16,9 +19,6 @@ if (require_git(2.19, 1)) {
 "git <2.19, cat-file lacks --unordered, locality suffers\n";
 }
 
-my $pi_dir = $ENV{GIANT_PI_DIR};
-plan skip_all => "GIANT_PI_DIR not defined for $0" unless $pi_dir;
-
 my $ibx = PublicInbox::Inbox->new({ mainrepo => $pi_dir, name => 'name' });
 my $git = $ibx->git;
 my $fh = $git->popen(@cat);
-- 
EW


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 2/2] t/perf-msgview.t: fix broken performance test
  2019-02-07 21:38 [PATCH 1/2] t/perf-msgview: don't warn about --unordered if skipping Eric Wong
@ 2019-02-07 21:38 ` Eric Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2019-02-07 21:38 UTC (permalink / raw)
  To: meta

WwwStream started depending on the WWW::style method
for configurable CSS, so mock ::style so the benchmark
runs properly.

Fixes: f026dbdd392c9dd5 ('www: admin-configurable CSS via "publicinbox.css"')
---
 t/perf-msgview.t | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/t/perf-msgview.t b/t/perf-msgview.t
index 4975305..0defafc 100644
--- a/t/perf-msgview.t
+++ b/t/perf-msgview.t
@@ -19,6 +19,7 @@ if (require_git(2.19, 1)) {
 "git <2.19, cat-file lacks --unordered, locality suffers\n";
 }
 
+use_ok 'Plack::Util';
 my $ibx = PublicInbox::Inbox->new({ mainrepo => $pi_dir, name => 'name' });
 my $git = $ibx->git;
 my $fh = $git->popen(@cat);
@@ -29,6 +30,7 @@ select($vec, undef, undef, 60) or die "timed out waiting for --batch-check";
 my $ctx = {
 	env => { HTTP_HOST => 'example.com', 'psgi.url_scheme' => 'https' },
 	-inbox => $ibx,
+	www => Plack::Util::inline_object(style => sub {''}),
 };
 my ($str, $mime, $res, $cmt, $type);
 my $n = 0;
-- 
EW


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-07 21:38 [PATCH 1/2] t/perf-msgview: don't warn about --unordered if skipping Eric Wong
2019-02-07 21:38 ` [PATCH 2/2] t/perf-msgview.t: fix broken performance test Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox