From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/2] t/perf-msgview: don't warn about --unordered if skipping
Date: Thu, 7 Feb 2019 21:38:24 +0000 [thread overview]
Message-ID: <20190207213825.19332-1-e@80x24.org> (raw)
No point in making noise about something that isn't used.
---
t/perf-msgview.t | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/perf-msgview.t b/t/perf-msgview.t
index adeb7aa..4975305 100644
--- a/t/perf-msgview.t
+++ b/t/perf-msgview.t
@@ -8,6 +8,9 @@ use PublicInbox::Inbox;
use PublicInbox::View;
require './t/common.perl';
+my $pi_dir = $ENV{GIANT_PI_DIR};
+plan skip_all => "GIANT_PI_DIR not defined for $0" unless $pi_dir;
+
my @cat = qw(cat-file --buffer --batch-check --batch-all-objects);
if (require_git(2.19, 1)) {
push @cat, '--unordered';
@@ -16,9 +19,6 @@ if (require_git(2.19, 1)) {
"git <2.19, cat-file lacks --unordered, locality suffers\n";
}
-my $pi_dir = $ENV{GIANT_PI_DIR};
-plan skip_all => "GIANT_PI_DIR not defined for $0" unless $pi_dir;
-
my $ibx = PublicInbox::Inbox->new({ mainrepo => $pi_dir, name => 'name' });
my $git = $ibx->git;
my $fh = $git->popen(@cat);
--
EW
next reply other threads:[~2019-02-07 21:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 21:38 Eric Wong [this message]
2019-02-07 21:38 ` [PATCH 2/2] t/perf-msgview.t: fix broken performance test Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207213825.19332-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).