From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, FROM_EXCESS_BASE64,RCVD_IN_DNSWL_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 60E791F453 for ; Mon, 4 Feb 2019 10:55:02 +0000 (UTC) Received: by mail-wr1-x42b.google.com with SMTP id q15so2907223wro.12 for ; Mon, 04 Feb 2019 02:55:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :content-transfer-encoding:user-agent; bh=mXgWAv+Kvi/p6fazMYNvQb5Mm6NEXlCCZVZcVW+ETh0=; b=up2Tt/fUBGJ5mdkvkAEe8cKX8xkRY8zcfmiJJvVsgZzwiwsIi743ObJaZjykuglBj8 nZR57Hb65yrN2/Gke6YHRt+BSC3xSjO3Yg87EeL8UjJ9+kwgMEOQy0W6jdhFGX+UpEd0 808cq8wbfINpqeSRM7SiXmUJsd0sSMKwFapuzo7gG2agrlXXwsDZxZEcCJb93j0n2Jfn QwtVr7pdLGIkDHlSVjDZhtItqeYrGy7QfkHu8Jrj/hq1f6tMzLXxii/gZdKhk9fblfOK ziT6fKNgobAOedBmneFvxUhu1bftuXeB3gTdIQEc440wmfHlIupLQtyasdF60emrX9cv 3uQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:content-transfer-encoding:user-agent; bh=mXgWAv+Kvi/p6fazMYNvQb5Mm6NEXlCCZVZcVW+ETh0=; b=uFfVt01epgyd9lud0qq+WNWmUaxStntvHKCIoWAi91vcrkCjrZDuPrk+me2Erm6dLa SSsDf4GJI535P6/D/rRcs24k8PL71ZDy40wiugA/saEQjOWnMYxUSvlt+B8JZIyNxcxo kkq3lrwJ9umQjzmeWaZj9EGdOB3AeSen3GHqZL2atSMbeTBB1/OTaXcU/DBXslT60CEg F2keNAmBxo7Lnn+IpkDy9AfC3MoZSPf2Qk4S0NJ6auhCpXylXqPC4PmVRnWTvO1OoWXo e2qDlWrKpBelD8NPKftHS5Zs5JtDKUzLBGRwQUmf3eC6/npsxdR26N/0aapPQqM/UEXw PZ4w== X-Gm-Message-State: AHQUAuaQLXD2X0+lUAsL/aIVpoR91Cz4OwDxE1ByDkY5oHj7X8BirffS 0oYqjHQXsOFhrmB+qnscIopeeOGSxPM= X-Google-Smtp-Source: AHgI3Ia4OL5dNcPPatlLWHHSOay5W0ZKFULymUPp1MMcog5BIN4LuOAwcGXKengQB2Ff1XM98gFXnw== X-Received: by 2002:a5d:5492:: with SMTP id h18mr12346921wrv.322.1549277697414; Mon, 04 Feb 2019 02:54:57 -0800 (PST) Received: from szeder.dev (x4db609fa.dyn.telefonica.de. [77.182.9.250]) by smtp.gmail.com with ESMTPSA id i186sm18034981wmd.19.2019.02.04.02.54.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 02:54:56 -0800 (PST) Date: Mon, 4 Feb 2019 11:54:54 +0100 From: SZEDER =?utf-8?B?R8OhYm9y?= To: meta@public-inbox.org Subject: syntax highlighting bug with lines containing '>' Message-ID: <20190204105454.GG10587@szeder.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: Hi, First of all, thanks you very much for adding syntax highlighting for patch emails, it's fantastic! However, I noticed that a patch I recently sent to the Git mailing list got bogus syntax highlighting, as the added line is colored as removed: https://public-inbox.org/git/20190202163421.19686-1-szeder.dev@gmail.com/ Perhaps the '>' shell redirection operator causes troubles? I clicked around in the list archives, and sure enough found other occurrance of this bug, that also seems to suggest that a '>' might be problematic only when it's on the first added line: https://public-inbox.org/git/20190203210027.13272-1-svenvh@gmail.com/ Dunno, I have no idea how any of this works, so I stop spinning theories about what could possibly be the cause. Gábor