user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] httpd: a few comments about some fields we set
Date: Wed, 30 Jan 2019 07:39:02 +0000	[thread overview]
Message-ID: <20190130073902.24011-1-e@80x24.org> (raw)

Removing 'psgix.input.buffered' could be a possibility in
the future.
---
 lib/PublicInbox/HTTPD.pm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/HTTPD.pm b/lib/PublicInbox/HTTPD.pm
index 3851771..b0bf94a 100644
--- a/lib/PublicInbox/HTTPD.pm
+++ b/lib/PublicInbox/HTTPD.pm
@@ -29,9 +29,16 @@ sub new {
 		'psgi.run_once'	 => Plack::Util::FALSE,
 		'psgi.multithread' => Plack::Util::FALSE,
 		'psgi.multiprocess' => Plack::Util::TRUE,
+
+		# We don't use this anywhere, but we can support
+		# other PSGI apps which might use it:
 		'psgix.input.buffered' => Plack::Util::TRUE,
 
-		# XXX unstable API!
+		# XXX unstable API!, only GitHTTPBackend needs
+		# this to limit git-http-backend(1) parallelism.
+		# The rest of our PSGI code is generic, relying
+		# on "pull" model using "getline" to prevent
+		# over-buffering.
 		'pi-httpd.async' => do {
 			no warnings 'once';
 			*pi_httpd_async
-- 
EW


                 reply	other threads:[~2019-01-30  7:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190130073902.24011-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).