user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <>
Subject: [PATCH 1/4] wwwhighlight: read_in_full returns undef on errors
Date: Sun, 27 Jan 2019 11:48:14 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

The return value of "print" is not undef for Perl IO::Handle.
 lib/PublicInbox/ | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index 3d6ca03..09fc48a 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -52,6 +52,7 @@ sub read_in_full ($) {
 		$off += $r;
 	$env->{'psgi.errors'}->print("input read error: $!\n");
+	undef;
 # entry point for PSGI

  reply	other threads:[~2019-01-27 11:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-27 11:48 [PATCH 0/4] viewvcs: wire up highlight to solver Eric Wong
2019-01-27 11:48 ` Eric Wong [this message]
2019-01-27 11:48 ` [PATCH 2/4] t/hl_mod: extra check to ensure we escape HTML Eric Wong
2019-01-27 11:48 ` [PATCH 3/4] hlmod: disable enclosing <pre> tag Eric Wong
2019-01-27 11:48 ` [PATCH 4/4] viewvcs: wire up syntax-highlighting for blobs Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).