From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 0601A2141D for ; Sun, 27 Jan 2019 04:03:43 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 04/14] qspawn|httpd/async: improve and fix out-of-date comments Date: Sun, 27 Jan 2019 04:03:31 +0000 Message-Id: <20190127040341.26107-5-e@80x24.org> In-Reply-To: <20190127040341.26107-1-e@80x24.org> References: <20190127040341.26107-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: --- lib/PublicInbox/HTTPD/Async.pm | 1 + lib/PublicInbox/Qspawn.pm | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/HTTPD/Async.pm b/lib/PublicInbox/HTTPD/Async.pm index a8488b6..a9a9573 100644 --- a/lib/PublicInbox/HTTPD/Async.pm +++ b/lib/PublicInbox/HTTPD/Async.pm @@ -23,6 +23,7 @@ sub new { $self; } +# fires after pending writes are complete: sub restart_read_cb ($) { my ($self) = @_; sub { $self->watch_read(1) } diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm index 3247cd0..96fbf38 100644 --- a/lib/PublicInbox/Qspawn.pm +++ b/lib/PublicInbox/Qspawn.pm @@ -86,8 +86,6 @@ sub psgi_return { $fh->close if $fh; # async-only }; - # Danga::Socket users, we queue up the read_enable callback to - # fire after pending writes are complete: my $buf = ''; my $rd_hdr = sub { my $r = sysread($rpipe, $buf, 1024, length($buf)); @@ -102,7 +100,7 @@ sub psgi_return { my $filter = delete $env->{'qspawn.filter'}; if (scalar(@$r) == 3) { # error if ($async) { - $async->close; # calls rpipe->close + $async->close; # calls rpipe->close and $end } else { $rpipe->close; $end->(); -- EW