From: Eric Wong <e@80x24.org> To: meta@public-inbox.org Subject: [PATCH 28/37] t/check-www-inbox: use xmlstarlet to validate Atom if available Date: Mon, 21 Jan 2019 20:52:44 +0000 Message-ID: <20190121205253.10455-29-e@80x24.org> (raw) In-Reply-To: <20190121205253.10455-1-e@80x24.org> I almost forgot about this script; but remembering to test it against real-world data can be useful to hunt for bugs. --- t/check-www-inbox.perl | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/t/check-www-inbox.perl b/t/check-www-inbox.perl index 08e6247..7dd1eeb 100644 --- a/t/check-www-inbox.perl +++ b/t/check-www-inbox.perl @@ -1,5 +1,5 @@ #!/usr/bin/perl -w -# Copyright (C) 2016-2018 all contributors <meta@public-inbox.org> +# Copyright (C) 2016-2019 all contributors <meta@public-inbox.org> # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt> # Parallel WWW checker my $usage = "$0 [-j JOBS] [-s SLOW_THRESHOLD] URL_OF_INBOX\n"; @@ -23,6 +23,16 @@ my %opts = ( GetOptions(%opts) or die "bad command-line args\n$usage"; my $root_url = shift or die $usage; +chomp(my $xmlstarlet = `which xmlstarlet 2>/dev/null`); +my $atom_check = eval { + require IPC::Run; + my $cmd = [ qw(xmlstarlet val -e -) ]; + sub { + my ($in, $out, $err) = @_; + IPC::Run::run($cmd, $in, $out, $err); + } +} if $xmlstarlet; + my %workers; $SIG{TERM} = sub { exit 0 }; $SIG{CHLD} = sub { @@ -146,7 +156,15 @@ sub worker_loop { # make sure the HTML source doesn't screw up terminals # when people curl the source (not remotely an expert # on languages or encodings, here). - next if $r->header('Content-Type') !~ m!\btext/html\b!; + my $ct = $r->header('Content-Type'); + if ($atom_check && $ct =~ m!\bapplication/atom\+xml\b!) { + my $raw = $r->decoded_content; + my ($out, $err) = ('', ''); + $atom_check->(\$raw, \$out, \$err) and + warn "Atom ($?) - $u - <1:$out> <2:$err>\n"; + } + + next if $ct !~ m!\btext/html\b!; my $dc = $r->decoded_content; if ($dc =~ /([\x00-\x08\x0d-\x1f\x7f-\x{99999999}]+)/s) { my $o = $1; -- EW
next prev parent reply other threads:[~2019-01-21 20:52 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-21 20:52 [PATCH 00/37] viewvcs: diff highlighting and more Eric Wong 2019-01-21 20:52 ` [PATCH 01/37] view: disable bold in topic display Eric Wong 2019-01-21 20:52 ` [PATCH 02/37] hval: force monospace for <form> elements, too Eric Wong 2019-01-21 20:52 ` [PATCH 03/37] t/perf-msgview: add test to check msg_html performance Eric Wong 2019-01-21 20:52 ` [PATCH 04/37] solver: initial Perl implementation Eric Wong 2019-01-21 20:52 ` [PATCH 05/37] git: support multiple URL endpoints Eric Wong 2019-01-21 20:52 ` [PATCH 06/37] git: add git_quote Eric Wong 2019-01-21 20:52 ` [PATCH 07/37] git: check saves error on disambiguation Eric Wong 2019-01-21 20:52 ` [PATCH 08/37] solver: various bugfixes and cleanups Eric Wong 2019-01-21 20:52 ` [PATCH 09/37] view: wire up diff and vcs viewers with solver Eric Wong 2019-01-21 20:52 ` [PATCH 10/37] git: disable abbreviations with cat-file hints Eric Wong 2019-01-21 20:52 ` [PATCH 11/37] solver: operate directly on git index Eric Wong 2019-01-21 20:52 ` [PATCH 12/37] view: enable naming hints for raw blob downloads Eric Wong 2019-01-21 20:52 ` [PATCH 13/37] git: support 'ambiguous' result from --batch-check Eric Wong 2019-01-21 20:52 ` [PATCH 14/37] solver: more verbose blob resolution Eric Wong 2019-01-21 20:52 ` [PATCH 15/37] solver: break up patch application steps Eric Wong 2019-01-21 20:52 ` [PATCH 16/37] solver: switch patch application to use a callback Eric Wong 2019-01-21 20:52 ` [PATCH 17/37] solver: simplify control flow for initial loop Eric Wong 2019-01-21 20:52 ` [PATCH 18/37] solver: break @todo loop into a callback Eric Wong 2019-01-21 20:52 ` [PATCH 19/37] solver: note the synchronous nature of index preparation Eric Wong 2019-01-21 20:52 ` [PATCH 20/37] solver: add a TODO note about making this fully evented Eric Wong 2019-01-21 20:52 ` [PATCH 21/37] view: enforce trailing slash for /$INBOX/$OID/s/ endpoints Eric Wong 2019-01-21 20:52 ` [PATCH 22/37] solver: restore diagnostics and deal with CRLF Eric Wong 2019-01-21 20:52 ` [PATCH 23/37] www: admin-configurable CSS via "publicinbox.css" Eric Wong 2019-01-21 20:52 ` [PATCH 24/37] $INBOX/_/text/color/ and sample user-side CSS Eric Wong 2019-01-21 20:52 ` [PATCH 25/37] viewdiff: support diff-highlighting w/o coderepo Eric Wong 2019-01-21 20:52 ` [PATCH 26/37] viewdiff: cleanup state transitions a bit Eric Wong 2019-01-21 20:52 ` [PATCH 27/37] viewdiff: quote attributes for Atom feed Eric Wong 2019-01-21 20:52 ` Eric Wong [this message] 2019-01-21 20:52 ` [PATCH 29/37] viewdiff: do not link to 0{7,40} blobs (again) Eric Wong 2019-01-21 20:52 ` [PATCH 30/37] viewvcs: disable white-space prewrap in blob view Eric Wong 2019-01-21 20:52 ` [PATCH 31/37] solver: force quoted-printable bodies to LF Eric Wong 2019-01-21 20:52 ` [PATCH 32/37] solver: remove extra "^index $OID..$OID" line Eric Wong 2019-01-21 20:52 ` [PATCH 33/37] config: each_inbox iteration preserves config order Eric Wong 2019-01-21 20:52 ` [PATCH 34/37] t/check-www-inbox: warn on missing Content-Type Eric Wong 2019-01-21 20:52 ` [PATCH 35/37] highlight: initial wrapper and PSGI service Eric Wong 2019-01-21 20:52 ` [PATCH 36/37] hval: split out escape sequences to a separate table Eric Wong 2019-01-21 20:52 ` [PATCH 37/37] t/check-www-inbox: trap SIGINT for File::Temp destruction Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190121205253.10455-29-e@80x24.org \ --to=e@80x24.org \ --cc=meta@public-inbox.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
user/dev discussion of public-inbox itself This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/meta git clone --mirror http://czquwvybam4bgbro.onion/meta git clone --mirror http://hjrcffqmbrq6wope.onion/meta git clone --mirror http://ou63pmih66umazou.onion/meta # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 meta meta/ https://public-inbox.org/meta \ meta@public-inbox.org public-inbox-index meta Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta nntp://news.gmane.io/gmane.mail.public-inbox.general note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/public-inbox.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git