From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id C1F0A1F453 for ; Mon, 21 Jan 2019 20:52:53 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 00/37] viewvcs: diff highlighting and more Date: Mon, 21 Jan 2019 20:52:16 +0000 Message-Id: <20190121205253.10455-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Still working on VCS integration and I'm not comfortable deploying this on the main public-inbox.org because of performance/fairness concerns, yet. But, perfect is the enemy of good and I figure it's worth publishing at the moment. It's also on a Tor mirror: http://hjrcffqmbrq6wope.onion/meta/ http://hjrcffqmbrq6wope.onion/git/ It looks great to me in Netsurf and dillo :> People with machines powerful enough to run Firefox (or Tor Browser Bundle) can use "View -> Page Style" to adjust colors. Performance considerations: * diff highlighting alone adds 10-20% overhead to message rendering Maybe I can speed it up with some less-readable Perl... * blob reconstruction is horribly unfair to other clients at the moment. Fixing this is a priority for me. I haven't hooked up highlight to blob viewing, yet; but that's coming; too. Thinking about it more, the blob lookups is so specific to git that I'm not sure other VCSes can be supported... The following changes since commit 55db8a2a51c13aec813ac56bbaac1505791fd262: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TODO: autolinkify that(!) t/git.t: do not pass "-b" to git-repack(1) (2019-01-18 22:00:33 +0000) are available in the Git repository at: https://public-inbox.org/ viewvcs for you to fetch changes up to c440c879d38e67f62bdbb74f616dc84d20899c33: t/check-www-inbox: trap SIGINT for File::Temp destruction (2019-01-21 06:53:35 +0000) ---------------------------------------------------------------- Eric Wong (37): view: disable bold in topic display hval: force monospace for
elements, too t/perf-msgview: add test to check msg_html performance solver: initial Perl implementation git: support multiple URL endpoints git: add git_quote git: check saves error on disambiguation solver: various bugfixes and cleanups view: wire up diff and vcs viewers with solver git: disable abbreviations with cat-file hints solver: operate directly on git index view: enable naming hints for raw blob downloads git: support 'ambiguous' result from --batch-check solver: more verbose blob resolution solver: break up patch application steps solver: switch patch application to use a callback solver: simplify control flow for initial loop solver: break @todo loop into a callback solver: note the synchronous nature of index preparation solver: add a TODO note about making this fully evented view: enforce trailing slash for /$INBOX/$OID/s/ endpoints solver: restore diagnostics and deal with CRLF www: admin-configurable CSS via "publicinbox.css" $INBOX/_/text/color/ and sample user-side CSS viewdiff: support diff-highlighting w/o coderepo viewdiff: cleanup state transitions a bit viewdiff: quote attributes for Atom feed t/check-www-inbox: use xmlstarlet to validate Atom if available viewdiff: do not link to 0{7,40} blobs (again) viewvcs: disable white-space prewrap in blob view solver: force quoted-printable bodies to LF solver: remove extra "^index $OID..$OID" line config: each_inbox iteration preserves config order t/check-www-inbox: warn on missing Content-Type highlight: initial wrapper and PSGI service hval: split out escape sequences to a separate table t/check-www-inbox: trap SIGINT for File::Temp destruction Documentation/design_www.txt | 6 +- MANIFEST | 15 + Makefile.PL | 3 + TODO | 2 - contrib/css/216dark.css | 26 ++ contrib/css/216light.css | 25 ++ contrib/css/README | 41 +++ examples/highlight.psgi | 13 + examples/public-inbox.psgi | 2 +- lib/PublicInbox/Config.pm | 96 +++++- lib/PublicInbox/Git.pm | 87 ++++- lib/PublicInbox/HlMod.pm | 126 ++++++++ lib/PublicInbox/Hval.pm | 38 +-- lib/PublicInbox/SolverGit.pm | 454 +++++++++++++++++++++++++++ lib/PublicInbox/UserContent.pm | 78 +++++ lib/PublicInbox/View.pm | 51 ++- lib/PublicInbox/ViewDiff.pm | 161 ++++++++++ lib/PublicInbox/ViewVCS.pm | 110 +++++++ lib/PublicInbox/WWW.pm | 152 ++++++++- lib/PublicInbox/WwwHighlight.pm | 73 +++++ lib/PublicInbox/WwwStream.pm | 4 +- lib/PublicInbox/WwwText.pm | 35 +++ script/public-inbox-httpd | 2 +- t/check-www-inbox.perl | 26 +- t/config.t | 19 ++ t/git.t | 7 +- t/hl_mod.t | 54 ++++ t/perf-msgview.t | 50 +++ t/solve/0001-simple-mod.patch | 20 ++ t/solve/0002-rename-with-modifications.patch | 37 +++ t/solver_git.t | 91 ++++++ t/view.t | 2 + 32 files changed, 1841 insertions(+), 65 deletions(-) create mode 100644 contrib/css/216dark.css create mode 100644 contrib/css/216light.css create mode 100644 contrib/css/README create mode 100644 examples/highlight.psgi create mode 100644 lib/PublicInbox/HlMod.pm create mode 100644 lib/PublicInbox/SolverGit.pm create mode 100644 lib/PublicInbox/UserContent.pm create mode 100644 lib/PublicInbox/ViewDiff.pm create mode 100644 lib/PublicInbox/ViewVCS.pm create mode 100644 lib/PublicInbox/WwwHighlight.pm create mode 100644 t/hl_mod.t create mode 100644 t/perf-msgview.t create mode 100644 t/solve/0001-simple-mod.patch create mode 100644 t/solve/0002-rename-with-modifications.patch create mode 100644 t/solver_git.t Eric Wong (37): view: disable bold in topic display hval: force monospace for elements, too t/perf-msgview: add test to check msg_html performance solver: initial Perl implementation git: support multiple URL endpoints git: add git_quote git: check saves error on disambiguation solver: various bugfixes and cleanups view: wire up diff and vcs viewers with solver git: disable abbreviations with cat-file hints solver: operate directly on git index view: enable naming hints for raw blob downloads git: support 'ambiguous' result from --batch-check solver: more verbose blob resolution solver: break up patch application steps solver: switch patch application to use a callback solver: simplify control flow for initial loop solver: break @todo loop into a callback solver: note the synchronous nature of index preparation solver: add a TODO note about making this fully evented view: enforce trailing slash for /$INBOX/$OID/s/ endpoints solver: restore diagnostics and deal with CRLF www: admin-configurable CSS via "publicinbox.css" $INBOX/_/text/color/ and sample user-side CSS viewdiff: support diff-highlighting w/o coderepo viewdiff: cleanup state transitions a bit viewdiff: quote attributes for Atom feed t/check-www-inbox: use xmlstarlet to validate Atom if available viewdiff: do not link to 0{7,40} blobs (again) viewvcs: disable white-space prewrap in blob view solver: force quoted-printable bodies to LF solver: remove extra "^index $OID..$OID" line config: each_inbox iteration preserves config order t/check-www-inbox: warn on missing Content-Type highlight: initial wrapper and PSGI service hval: split out escape sequences to a separate table t/check-www-inbox: trap SIGINT for File::Temp destruction Documentation/design_www.txt | 6 +- MANIFEST | 15 + Makefile.PL | 3 + TODO | 2 - contrib/css/216dark.css | 26 ++ contrib/css/216light.css | 25 + contrib/css/README | 41 ++ examples/highlight.psgi | 13 + examples/public-inbox.psgi | 2 +- lib/PublicInbox/Config.pm | 96 +++- lib/PublicInbox/Git.pm | 87 +++- lib/PublicInbox/HlMod.pm | 126 +++++ lib/PublicInbox/Hval.pm | 38 +- lib/PublicInbox/SolverGit.pm | 454 +++++++++++++++++++ lib/PublicInbox/UserContent.pm | 78 ++++ lib/PublicInbox/View.pm | 51 ++- lib/PublicInbox/ViewDiff.pm | 161 +++++++ lib/PublicInbox/ViewVCS.pm | 110 +++++ lib/PublicInbox/WWW.pm | 152 ++++++- lib/PublicInbox/WwwHighlight.pm | 73 +++ lib/PublicInbox/WwwStream.pm | 4 +- lib/PublicInbox/WwwText.pm | 35 ++ script/public-inbox-httpd | 2 +- t/check-www-inbox.perl | 26 +- t/config.t | 19 + t/git.t | 7 +- t/hl_mod.t | 54 +++ t/perf-msgview.t | 50 ++ t/solve/0001-simple-mod.patch | 20 + t/solve/0002-rename-with-modifications.patch | 37 ++ t/solver_git.t | 91 ++++ t/view.t | 2 + 32 files changed, 1841 insertions(+), 65 deletions(-) create mode 100644 contrib/css/216dark.css create mode 100644 contrib/css/216light.css create mode 100644 contrib/css/README create mode 100644 examples/highlight.psgi create mode 100644 lib/PublicInbox/HlMod.pm create mode 100644 lib/PublicInbox/SolverGit.pm create mode 100644 lib/PublicInbox/UserContent.pm create mode 100644 lib/PublicInbox/ViewDiff.pm create mode 100644 lib/PublicInbox/ViewVCS.pm create mode 100644 lib/PublicInbox/WwwHighlight.pm create mode 100644 t/hl_mod.t create mode 100644 t/perf-msgview.t create mode 100644 t/solve/0001-simple-mod.patch create mode 100644 t/solve/0002-rename-with-modifications.patch create mode 100644 t/solver_git.t