* [PATCH] git: git_unquote handles double-quote and backslash
@ 2019-01-18 22:01 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-01-18 22:01 UTC (permalink / raw)
To: meta
We need to work with 0x22 (double-quote) and 0x5c (backslash);
even if they're oddball characters in filenames which wouldn't
be used by projects I'd want to work on.
---
lib/PublicInbox/Git.pm | 4 +++-
t/git.t | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 4601f25..90b9214 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -23,13 +23,15 @@ my %GIT_ESC = (
r => "\r",
t => "\t",
v => "\013",
+ '"' => '"',
+ '\\' => '\\',
);
# unquote pathnames used by git, see quote.c::unquote_c_style.c in git.git
sub git_unquote ($) {
return $_[0] unless ($_[0] =~ /\A"(.*)"\z/);
$_[0] = $1;
- $_[0] =~ s/\\([abfnrtv])/$GIT_ESC{$1}/g;
+ $_[0] =~ s/\\([\\"abfnrtv])/$GIT_ESC{$1}/g;
$_[0] =~ s/\\([0-7]{1,3})/chr(oct($1))/ge;
$_[0];
}
diff --git a/t/git.t b/t/git.t
index 052e1ce..c642b8f 100644
--- a/t/git.t
+++ b/t/git.t
@@ -148,5 +148,7 @@ use_ok 'PublicInbox::Git', qw(git_unquote);
my $s;
is("foo\nbar", git_unquote($s = '"foo\\nbar"'), 'unquoted newline');
is("Eléanor", git_unquote($s = '"El\\303\\251anor"'), 'unquoted octal');
+is(git_unquote($s = '"I\"m"'), 'I"m', 'unquoted dq');
+is(git_unquote($s = '"I\\m"'), 'I\\m', 'unquoted backslash');
done_testing();
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-01-18 22:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-18 22:01 [PATCH] git: git_unquote handles double-quote and backslash Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).