From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id C377A211B5 for ; Thu, 10 Jan 2019 21:35:49 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/7] searchmsg: get rid of termlist scanning for mid Date: Thu, 10 Jan 2019 21:35:44 +0000 Message-Id: <20190110213549.19778-3-e@80x24.org> In-Reply-To: <20190110213549.19778-1-e@80x24.org> References: <20190110213549.19778-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: It doesn't seem to be used anywhere --- lib/PublicInbox/SearchMsg.pm | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/lib/PublicInbox/SearchMsg.pm b/lib/PublicInbox/SearchMsg.pm index c7787ea..5a2ca83 100644 --- a/lib/PublicInbox/SearchMsg.pm +++ b/lib/PublicInbox/SearchMsg.pm @@ -157,29 +157,17 @@ sub references { defined $x ? $x : ''; } -sub _get_term_val ($$$) { - my ($self, $pfx, $re) = @_; - my $doc = $self->{doc}; - my $end = $doc->termlist_end; - my $i = $doc->termlist_begin; - $i->skip_to($pfx); - if ($i != $end) { - my $val = $i->get_termname; - $val =~ s/$re// and return $val; - } - undef; -} - sub mid ($;$) { my ($self, $mid) = @_; if (defined $mid) { $self->{mid} = $mid; - } elsif (my $rv = $self->{mid}) { + } elsif (defined(my $rv = $self->{mid})) { $rv; } elsif ($self->{doc}) { - $self->{mid} = _get_term_val($self, 'Q', qr/\AQ/); + die "SHOULD NOT HAPPEN\n"; } else { + die "NO {mime} for mid\n" unless $self->{mime}; $self->_extract_mid; # v1 w/o Xapian } } -- EW