user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <>
Subject: [REJECT] watchmaildir: spam checking and learning improvements
Date: Thu, 10 Jan 2019 09:19:55 +0000	[thread overview]
Message-ID: <20190110091955.7q6px5cwmiisjo6v@dcvr> (raw)
In-Reply-To: <>

Eric Wong <> wrote:
> It turns out spam training ("spamc -L spam") was never implemented
> for -watch.  So implement that, and take advantage of an
> existing feature to pass FDs directly to spamc(1) instead of
> reconverting the MIME object into a string.

Will keep that...

> While we're at it, the spam-checking call is now only performed
> once per message when a Maildir supports multiple inboxes.

And that.

> This changes PublicInbox::Import::add (and V2Writable
> equivalent) API to no longer perform spam-checking.

But nope, we need to do spam-checking inside ->add;
because we don't want to waste cycles re-spam-checking
messages which are already in our archives on -watch

And the V2Writable->add spam-checking is in the wrong place.

      reply	other threads:[~2019-01-10  9:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10  9:02 [PATCH] watchmaildir: spam checking and learning improvements Eric Wong
2019-01-10  9:19 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190110091955.7q6px5cwmiisjo6v@dcvr \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).