From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id A0F011F803 for ; Tue, 8 Jan 2019 10:34:46 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] view: fix wrong date for non-Xapian/SQLite v1 users Date: Tue, 8 Jan 2019 10:34:46 +0000 Message-Id: <20190108103446.14004-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We need to parse the MIME object in order to get the datestamp for those sites. Fixes: 7d02b9e64455 ("view: stop storing all MIME objects on large threads") --- lib/PublicInbox/View.pm | 3 ++- t/plack.t | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 416cb4a..5ddb842 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -218,11 +218,12 @@ sub index_entry { $rv .= $subj . "\n"; $rv .= _th_index_lite($mid_raw, \$irt, $id, $ctx); my @tocc; + my $ds = $smsg->ds; # for v1 non-Xapian/SQLite users my $mime = delete $smsg->{mime}; # critical to memory use my $hdr = $mime->header_obj; my $from = _hdr_names_html($hdr, 'From'); obfuscate_addrs($obfs_ibx, $from) if $obfs_ibx; - $rv .= "From: $from @ ".fmt_ts($smsg->ds)." UTC"; + $rv .= "From: $from @ ".fmt_ts($ds)." UTC"; my $upfx = $ctx->{-upfx}; my $mhref = $upfx . mid_escape($mid_raw) . '/'; $rv .= qq{ (permalink / }; diff --git a/t/plack.t b/t/plack.t index 9901186..2ff98e9 100644 --- a/t/plack.t +++ b/t/plack.t @@ -46,7 +46,7 @@ To: You Cc: $addr Message-Id: Subject: hihi -Date: Thu, 01 Jan 1970 00:00:00 +0000 +Date: Fri, 02 Oct 1993 00:00:00 +0000 zzzzzz EOF @@ -129,6 +129,7 @@ EOF 'atom URL generated'); like($res->content, qr!href="blah\@example\.com/"!, 'index generated'); + like($res->content, qr!1993-10-02!, 'date set'); }); test_psgi($app, sub { -- EW