user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 5/6] t/cgi.t: move expected failure tests to t/plack.t
Date: Fri,  4 Jan 2019 13:10:37 +0000	[thread overview]
Message-ID: <20190104131038.32233-6-e@80x24.org> (raw)
In-Reply-To: <20190104131038.32233-1-e@80x24.org>

No point in implementing these slowly with the CGI wrapper
when PSGI is sufficient for testing.
---
 t/cgi.t   | 10 ----------
 t/plack.t | 13 +++++++++++++
 2 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/t/cgi.t b/t/cgi.t
index a25d2ee..e705cd7 100644
--- a/t/cgi.t
+++ b/t/cgi.t
@@ -80,16 +80,6 @@ EOF
 	$im->done;
 }
 
-# obvious failures, first
-{
-	local $ENV{HOME} = $home;
-	my $res = cgi_run("/", "", "PUT");
-	like($res->{head}, qr/Status:\s*405/i, "PUT not allowed");
-
-	$res = cgi_run("/");
-	like($res->{head}, qr/Status:\s*404/i, "index returns 404");
-}
-
 # message-id pages
 {
 	local $ENV{HOME} = $home;
diff --git a/t/plack.t b/t/plack.t
index 14c9b65..9901186 100644
--- a/t/plack.t
+++ b/t/plack.t
@@ -240,6 +240,19 @@ EOF
 		is(206, $res->code, 'got partial another response');
 		is($res->content, substr($orig, 5), 'partial body OK past end');
 	});
+
+	# things which should fail
+	test_psgi($app, sub {
+		my ($cb) = @_;
+
+		my $res = $cb->(PUT('/'));
+		is(405, $res->code, 'no PUT to / allowed');
+		$res = $cb->(PUT('/test/'));
+		is(405, $res->code, 'no PUT /$INBOX allowed');
+
+		# TODO
+		# $res = $cb->(GET('/'));
+	});
 }
 
 done_testing();
-- 
EW


  parent reply	other threads:[~2019-01-04 13:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04 13:10 [PATCH 0/6] t/cgi.t: test speedups and cleanups Eric Wong
2019-01-04 13:10 ` [PATCH 1/6] t/cgi.t: eliminate some cruft and unnecessary tests Eric Wong
2019-01-04 13:10 ` [PATCH 2/6] t/cgi.t: remove redundant redirect check Eric Wong
2019-01-04 13:10 ` [PATCH 3/6] t/cgi.t: remove atom.xml test Eric Wong
2019-01-04 13:10 ` [PATCH 4/6] t/cgi.t: move dumb HTTP git clone/fetch tests to plack.t Eric Wong
2019-01-04 13:10 ` Eric Wong [this message]
2019-01-04 13:10 ` [PATCH 6/6] t/cgi.t: remove more redundant tests Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190104131038.32233-6-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).