user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/6] t/cgi.t: remove atom.xml test
Date: Fri,  4 Jan 2019 13:10:35 +0000	[thread overview]
Message-ID: <20190104131038.32233-4-e@80x24.org> (raw)
In-Reply-To: <20190104131038.32233-1-e@80x24.org>

It is redundant with what is in t/plack.t
---
 t/cgi.t   | 12 ------------
 t/plack.t |  7 +++++--
 2 files changed, 5 insertions(+), 14 deletions(-)

diff --git a/t/cgi.t b/t/cgi.t
index 06519c3..382c21f 100644
--- a/t/cgi.t
+++ b/t/cgi.t
@@ -109,18 +109,6 @@ EOF
 	is($res->{body}, substr($orig, 5), 'partial body OK past end');
 }
 
-# atom feeds
-{
-	local $ENV{HOME} = $home;
-	my $res = cgi_run("/test/atom.xml");
-	like($res->{body}, qr/<title>test for public-inbox/,
-		"set title in XML feed");
-	like($res->{body},
-		qr!http://test\.example\.com/test/blah\@example\.com/!,
-		"link id set");
-	like($res->{body}, qr/what\?/, "reply included");
-}
-
 # message-id pages
 {
 	local $ENV{HOME} = $home;
diff --git a/t/plack.t b/t/plack.t
index 70cd20e..1a719b4 100644
--- a/t/plack.t
+++ b/t/plack.t
@@ -135,9 +135,12 @@ EOF
 		my ($cb) = @_;
 		my $res = $cb->(GET($pfx . '/atom.xml'));
 		is(200, $res->code, 'success response received for atom');
-		like($res->content,
-			qr!link\s+href="\Q$pfx\E/blah\@example\.com/"!s,
+		my $body = $res->content;
+		like($body, qr!link\s+href="\Q$pfx\E/blah\@example\.com/"!s,
 			'atom feed generated correct URL');
+		like($body, qr/<title>test for public-inbox/,
+			"set title in XML feed");
+		like($body, qr/zzzzzz/, 'body included');
 	});
 
 	test_psgi($app, sub {
-- 
EW


  parent reply	other threads:[~2019-01-04 13:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04 13:10 [PATCH 0/6] t/cgi.t: test speedups and cleanups Eric Wong
2019-01-04 13:10 ` [PATCH 1/6] t/cgi.t: eliminate some cruft and unnecessary tests Eric Wong
2019-01-04 13:10 ` [PATCH 2/6] t/cgi.t: remove redundant redirect check Eric Wong
2019-01-04 13:10 ` Eric Wong [this message]
2019-01-04 13:10 ` [PATCH 4/6] t/cgi.t: move dumb HTTP git clone/fetch tests to plack.t Eric Wong
2019-01-04 13:10 ` [PATCH 5/6] t/cgi.t: move expected failure tests to t/plack.t Eric Wong
2019-01-04 13:10 ` [PATCH 6/6] t/cgi.t: remove more redundant tests Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190104131038.32233-4-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).