From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/2] t/cgi.t: shorten %ENV setting
Date: Sat, 29 Dec 2018 03:47:22 +0000 [thread overview]
Message-ID: <20181229034722.16949-3-e@80x24.org> (raw)
In-Reply-To: <20181229034722.16949-1-e@80x24.org>
No need to write our own loop when an assignment will do.
---
t/cgi.t | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/t/cgi.t b/t/cgi.t
index 2e2476d..d92749b 100644
--- a/t/cgi.t
+++ b/t/cgi.t
@@ -217,8 +217,7 @@ done_testing();
sub run_with_env {
my ($env, @args) = @_;
- my $init = sub { foreach my $k (keys %$env) { $ENV{$k} = $env->{$k} } };
- IPC::Run::run(@args, init => $init);
+ IPC::Run::run(@args, init => sub { %ENV = (%ENV, %$env) });
}
sub cgi_run {
--
EW
prev parent reply other threads:[~2018-12-29 3:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 3:47 [PATCH 0/2] test cleanups Eric Wong
2018-12-29 3:47 ` [PATCH 1/2] tests: consolidate process spawning code Eric Wong
2018-12-29 5:51 ` [PATCH 3/2] t/git.t: reorder IPC::Run check Eric Wong
2018-12-29 3:47 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181229034722.16949-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).