user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] init: allow --skip of old epochs for -V2 repos
@ 2018-12-28 10:16 Eric Wong
  0 siblings, 0 replies; 1+ messages in thread
From: Eric Wong @ 2018-12-28 10:16 UTC (permalink / raw)
  To: meta

This allows archivists to publish incomplete archives with newer
mail while allowing "0.git" (or "1.git" and so on) epochs to be
added-after-the-fact (without affecting "git clone" followers).

A reindex will be necessary for Xapian and SQLite to catch up
once the old epochs are added; but the reindexing code is also
capable of tolerating missing epochs.
---
 lib/PublicInbox/V2Writable.pm |  5 ++++-
 script/public-inbox-init      |  8 +++++++-
 t/init.t                      | 16 ++++++++++++++++
 3 files changed, 27 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index 0396d9f..152d90a 100644
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -83,11 +83,14 @@ sub new {
 }
 
 sub init_inbox {
-	my ($self, $parallel) = @_;
+	my ($self, $parallel, $skip) = @_;
 	$self->{parallel} = $parallel;
 	$self->idx_init;
 	my $epoch_max = -1;
 	git_dir_latest($self, \$epoch_max);
+	if (defined $skip && $epoch_max == -1) {
+		$epoch_max = $skip;
+	}
 	$self->git_init($epoch_max >= 0 ? $epoch_max : 0);
 	$self->done;
 }
diff --git a/script/public-inbox-init b/script/public-inbox-init
index 1aec799..39f7497 100755
--- a/script/public-inbox-init
+++ b/script/public-inbox-init
@@ -17,8 +17,10 @@ sub x { system(@_) and die join(' ', @_). " failed: $?\n" }
 sub usage { print STDERR "Usage: $usage\n"; exit 1 }
 my $version = undef;
 my $indexlevel = undef;
+my $skip;
 my %opts = ( 'V|version=i' => \$version,
 	     'L|indexlevel=s' => \$indexlevel,
+	     'S|skip=i' => \$skip,
 );
 GetOptions(%opts) or usage();
 my $name = shift @ARGV or usage();
@@ -97,6 +99,10 @@ if (-f "$mainrepo/inbox.lock") {
 
 $version = 1 unless defined $version;
 
+if ($version == 1 && defined $skip) {
+	die "--skip is only supported for -V2 repos\n";
+}
+
 if ($version >= 2) {
 	require PublicInbox::V2Writable;
 	require PublicInbox::Inbox;
@@ -107,7 +113,7 @@ if ($version >= 2) {
 		-primary_address => $address[0],
 	};
 	$ibx = PublicInbox::Inbox->new($ibx);
-	PublicInbox::V2Writable->new($ibx, 1)->init_inbox(0);
+	PublicInbox::V2Writable->new($ibx, 1)->init_inbox(0, $skip);
 } elsif ($version == 1) {
 	x(qw(git init -q --bare), $mainrepo);
 
diff --git a/t/init.t b/t/init.t
index 182d065..1551a30 100644
--- a/t/init.t
+++ b/t/init.t
@@ -79,6 +79,22 @@ SKIP: {
 		is(system(@cmd), 0, "-init -L $lvl");
 		is(read_indexlevel("v2$lvl"), $lvl, "indexlevel set to '$lvl'");
 	}
+
+	# loop for idempotency
+	for (1..2) {
+		@cmd = (pi_init, '-V2', '-S1', 'skip1', "$tmpdir/skip1",
+			   qw(http://example.com/skip1 skip1@example.com));
+		is(system(@cmd), 0, "--skip 1");
+		my $gits = [ glob("$tmpdir/skip1/git/*.git") ];
+		is_deeply(["$tmpdir/skip1/git/1.git"], $gits, 'skip OK');
+	}
+
+
+	@cmd = (pi_init, '-V2', '--skip=2', 'skip2', "$tmpdir/skip2",
+		   qw(http://example.com/skip2 skip2@example.com));
+	is(system(@cmd), 0, "--skip 2");
+	my $gits = [ glob("$tmpdir/skip2/git/*.git") ];
+	is_deeply(["$tmpdir/skip2/git/2.git"], $gits, 'skipping 2 works, too');
 }
 
 done_testing();
-- 
EW


^ permalink raw reply	[flat|nested] 1+ messages in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-28 10:16 [PATCH] init: allow --skip of old epochs for -V2 repos Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox