user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] reply: allow ":none=$REASON" in "replyto" config
Date: Fri, 28 Dec 2018 00:24:12 +0000	[thread overview]
Message-ID: <20181228002412.29022-1-e@80x24.org> (raw)

This can be useful for configuring archives of lists which are
no longer active.
---
 lib/PublicInbox/Reply.pm | 10 +++++++++-
 lib/PublicInbox/View.pm  |  3 +++
 t/reply.t                |  5 +++++
 3 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Reply.pm b/lib/PublicInbox/Reply.pm
index 17b1abb..11e17ed 100644
--- a/lib/PublicInbox/Reply.pm
+++ b/lib/PublicInbox/Reply.pm
@@ -34,8 +34,16 @@ sub mailto_arg_link {
 	my $cc = {}; # everyone else
 	my $to; # this is the From address by defaultq
 	my $reply_to_all = 'reply-to-all'; # the only good default :P
+	my $reply_to_cfg = $ibx->{replyto};
 
-	foreach my $rt (split(/\s*,\s*/, $ibx->{replyto} || ':all')) {
+	$reply_to_cfg ||= ':all';
+	if ($reply_to_cfg =~ /\A:none=(.*)/) {
+		my $msg = $1;
+		$msg = 'replies disabled' if $msg eq '';
+		return \$msg;
+	}
+
+	foreach my $rt (split(/\s*,\s*/, $reply_to_cfg)) {
 		if ($rt eq ':all') {
 			foreach my $h (@reply_headers) {
 				my $v = $hdr->header($h);
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index eb002ae..86acd82 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -119,6 +119,9 @@ sub msg_reply {
 
 	my ($arg, $link, $reply_to_all) =
 			PublicInbox::Reply::mailto_arg_link($ibx, $hdr);
+	if (ref($arg) eq 'SCALAR') {
+		return '<pre id=R>'.ascii_html($$arg).'</pre>';
+	}
 
 	# mailto: link only works if address obfuscation is disabled
 	if ($link) {
diff --git a/t/reply.t b/t/reply.t
index de31f88..cbcd722 100644
--- a/t/reply.t
+++ b/t/reply.t
@@ -76,4 +76,9 @@ $exp = [
 is_deeply($arg, $exp, 'address obfuscation works');
 is($link, '', 'no mailto: link given');
 
+$ibx->{replyto} = ':none=dead list';
+$ibx->{obfuscate} = 1;
+($arg, $link) = PublicInbox::Reply::mailto_arg_link($ibx, $hdr);
+is($$arg, 'dead list', ':none= works');
+
 done_testing();
-- 
EW


                 reply	other threads:[~2018-12-28  0:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181228002412.29022-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).