user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] Import.pm: Deal with potentially missing From and Sender headers
Date: Thu, 19 Jul 2018 20:44:57 +0000	[thread overview]
Message-ID: <20180719204457.mbnklcamdklhnjmr@whir> (raw)
In-Reply-To: <87zhyndnls.fsf@xmission.com>

"Eric W. Biederman" <ebiederm@xmission.com> wrote:
> 
> Use ||= '' to ensure that if the From or Sender header is not present
> the code sees an empty string and instead of undefined.
> 
> I had some email messages with a From field without an @ (because the
> sender was local) and without a Sender which were causing errors when
> imported.  I think this was bad enough that the email messages were
> failing to be imported.

Thanks, pushed to master as ce5af2029b6bc703f3d8cf7bb5c68732c41f210e.

I assume this is from testing against personal mail?
I haven't tried that, yet :x

  reply	other threads:[~2018-07-19 20:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 19:36 [PATCH] Import.pm: Deal with potentially missing From and Sender headers Eric W. Biederman
2018-07-19 20:44 ` Eric Wong [this message]
2018-07-19 20:48   ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180719204457.mbnklcamdklhnjmr@whir \
    --to=e@80x24.org \
    --cc=ebiederm@xmission.com \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).