From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B65CD1F85E; Fri, 13 Jul 2018 22:02:59 +0000 (UTC) Date: Fri, 13 Jul 2018 22:02:59 +0000 From: Eric Wong To: "Eric W. Biederman" Cc: meta@public-inbox.org Subject: bug: v2 deletes on incremental fetch [was: Q: V2 format] Message-ID: <20180713220259.GA27845@dcvr> References: <87k1q1bky6.fsf@xmission.com> <20180712014715.dn5aouayoa3uejp4@dcvr> <87k1q07dyc.fsf@xmission.com> <20180712230946.mqv3yjw4aabf7xrf@dcvr.yhbt.net> <878t6f1ch7.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878t6f1ch7.fsf@xmission.com> List-Id: "Eric W. Biederman" wrote: > Eric Wong writes: > > "Eric W. Biederman" wrote: > >> Then I am going to report a probable bug. In V2 in public-inbox-index > >> I can not find a path from finding a 'd' file and a call to unindex. V1 > >> unindexes deleted files. Rebased heads for purges call unindex. I > >> don't see that for ordinary d files though. > > > > It shouldn't need to call unindex because they never get indexed > > on rebuilds. V2 indexing walks history backwards (normal "git log" > > behavior) so it remembers 'd' paths in the "$D" hash; and skips blobs > > as it encounters them. > > > > v1 needed to unindex because it used "git log --reverse" to walk > > forward in history. > > This assumes that you see them in the same git pull. I would think > ideally anything that is going to be deleted that quickly you can just > skip archiving. > > What is the time window of you expecting 'd' messages to appear? Ah, this is definitely a bug when using incremental fetch + -index. Right now, it only warns on unseen entries in $D but won't reach beyond the current "git log" window. I'll take a lookg at it later today/this weekend unless you're already working on it.