user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/3] view: drop redundant References: display code
Date: Mon, 23 Apr 2018 04:16:54 +0000	[thread overview]
Message-ID: <20180423041654.4152-4-e@80x24.org> (raw)
In-Reply-To: <20180423041654.4152-1-e@80x24.org>

We no longer need to parse and dedupe References:
ourselves, PublicInbox::MID::references does it for us.
---
 lib/PublicInbox/View.pm | 22 +++++-----------------
 1 file changed, 5 insertions(+), 17 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 7339467..58851ed 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -723,7 +723,8 @@ sub _parent_headers {
 	my ($hdr, $srch) = @_;
 	my $rv = '';
 
-	my $irt = in_reply_to($hdr);
+	my $refs = references($hdr);
+	my $irt = pop @$refs;
 	if (defined $irt) {
 		my $v = PublicInbox::Hval->new_msgid($irt);
 		my $html = $v->as_html;
@@ -736,22 +737,9 @@ sub _parent_headers {
 	# we show the thread skeleton at the bottom, instead.
 	return $rv if $srch;
 
-	my $refs = $hdr->header_raw('References');
-	if ($refs) {
-		# avoid redundant URLs wasting bandwidth
-		my %seen;
-		$seen{$irt} = 1 if defined $irt;
-		my @refs;
-		my @raw_refs = ($refs =~ /<([^>]+)>/g);
-		foreach my $ref (@raw_refs) {
-			next if $seen{$ref};
-			$seen{$ref} = 1;
-			push @refs, linkify_ref_nosrch($ref);
-		}
-
-		if (@refs) {
-			$rv .= 'References: '. join("\n\t", @refs) . "\n";
-		}
+	if (@$refs) {
+		@$refs = map { linkify_ref_nosrch($_) } @$refs;
+		$rv .= 'References: '. join("\n\t", @$refs) . "\n";
 	}
 	$rv;
 }
-- 
EW


      parent reply	other threads:[~2018-04-23  4:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23  4:16 [PATCH 0/3] view: wrap long To:/Cc: lists Eric Wong
2018-04-23  4:16 ` [PATCH 1/3] view: untangle loop when showing message headers Eric Wong
2018-04-23  4:16 ` [PATCH 2/3] view: wrap To: and Cc: headers in HTML display Eric Wong
2018-04-23  4:16 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180423041654.4152-4-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).