user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: "Eric Wong (Contractor, The Linux Foundation)" <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH v2 0/21] UI bits and v2 import fixes
Date: Wed, 28 Feb 2018 23:41:41 +0000	[thread overview]
Message-ID: <20180228234202.8839-1-e@80x24.org> (raw)

The most important fix was fixing a long-standing bug (also in v1)
with "searchidx: do not modify Xapian DB while iterating".
It turns out my initial v2 import was missing a bit of data
and got threading wrong when Subjects were mismatched (every
patch series).  Unfortunately that means the import times I
initially reported were too  optimistic and real import times
may take 30-40% longer :<  (More optimizations are planned, however)

Fortunately, old optimizations made to avoid git tree lookups
during the v1 era has made v2 UI work much easier and I was able
to spot some errors and bugs quickly in the PSGI interface.

For sorting, relying on the Date: header seems unreliable as
kernel developers seem more prone to having bad clocks than
other lists I've imported.  I'll probably switch the internal
timestamps to use the Received: date as a result.

Eric Wong (Contractor, The Linux Foundation) (21):
  v2writable: warn on duplicate Message-IDs
  v2/ui: some hacky things to get the PSGI UI to show up
  v2/ui: retry DB reopens in a few more places
  v2writable: cleanup unused pipes in partitions
  searchidxpart: binmode
  use PublicInbox::MIME consistently
  searchidxpart: chomp line before splitting
  searchidx*: name child subprocesses
  searchidx: get rid of pointless index_blob wrapper
  view: remove X-PI-TS reference
  searchidxthread: load doc data for references
  searchidxpart: force integers into add_message
  search: reopen skeleton DB as well
  searchidx: index values in the threader
  search: use different Enquire object for skeleton queries
  rename SearchIdxThread to SearchIdxSkeleton
  v2writable: commit to skeleton via remote partitions
  searchidxskeleton: extra error checking
  searchidx: do not modify Xapian DB while iterating
  search: query_xover uses skeleton DB iff available
  v2/ui: get nntpd and init tests running on v2

 MANIFEST                                           |  2 +-
 lib/PublicInbox/Import.pm                          |  7 ++
 lib/PublicInbox/Inbox.pm                           | 23 +++++--
 lib/PublicInbox/MIME.pm                            |  2 +
 lib/PublicInbox/Search.pm                          | 74 ++++++++++++++++++++--
 lib/PublicInbox/SearchIdx.pm                       | 72 +++++++++++----------
 lib/PublicInbox/SearchIdxPart.pm                   | 27 +++++---
 .../{SearchIdxThread.pm => SearchIdxSkeleton.pm}   | 50 +++++++++------
 lib/PublicInbox/V2Writable.pm                      | 50 +++++++++------
 lib/PublicInbox/View.pm                            |  3 +-
 lib/PublicInbox/WatchMaildir.pm                    |  2 -
 lib/PublicInbox/WwwAttach.pm                       |  3 +-
 script/public-inbox-init                           | 48 ++++++++++----
 script/public-inbox-learn                          |  2 -
 script/public-inbox-mda                            |  4 +-
 scripts/import_slrnspool                           |  4 +-
 scripts/import_vger_from_mbox                      |  3 +-
 t/init.t                                           | 15 +++++
 t/nntpd.t                                          | 36 +++++++++--
 19 files changed, 302 insertions(+), 125 deletions(-)
 rename lib/PublicInbox/{SearchIdxThread.pm => SearchIdxSkeleton.pm} (63%)


             reply	other threads:[~2018-02-28 23:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 23:41 Eric Wong (Contractor, The Linux Foundation) [this message]
2018-02-28 23:41 ` [PATCH 01/21] v2writable: warn on duplicate Message-IDs Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 02/21] v2/ui: some hacky things to get the PSGI UI to show up Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 03/21] v2/ui: retry DB reopens in a few more places Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 04/21] v2writable: cleanup unused pipes in partitions Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 05/21] searchidxpart: binmode Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 06/21] use PublicInbox::MIME consistently Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 07/21] searchidxpart: chomp line before splitting Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 08/21] searchidx*: name child subprocesses Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 09/21] searchidx: get rid of pointless index_blob wrapper Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 10/21] view: remove X-PI-TS reference Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 11/21] searchidxthread: load doc data for references Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 12/21] searchidxpart: force integers into add_message Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 13/21] search: reopen skeleton DB as well Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 14/21] searchidx: index values in the threader Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 15/21] search: use different Enquire object for skeleton queries Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 16/21] rename SearchIdxThread to SearchIdxSkeleton Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 17/21] v2writable: commit to skeleton via remote partitions Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:41 ` [PATCH 18/21] searchidxskeleton: extra error checking Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:42 ` [PATCH 19/21] searchidx: do not modify Xapian DB while iterating Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:42 ` [PATCH 20/21] search: query_xover uses skeleton DB iff available Eric Wong (Contractor, The Linux Foundation)
2018-02-28 23:42 ` [PATCH 21/21] v2/ui: get nntpd and init tests running on v2 Eric Wong (Contractor, The Linux Foundation)
2018-03-01 23:40 ` [PATCH v2 0/21] UI bits and v2 import fixes Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180228234202.8839-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).