From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] view: allow expanding directly to "nested" view
Date: Sat, 3 Feb 2018 02:55:33 +0000 [thread overview]
Message-ID: <20180203025533.26725-1-e@80x24.org> (raw)
Sometimes, it can be desirable to jump directly to the "nested"
view when viewing a thread skeleton. This makes it possible.
While we're at it, shorten some of the text to ensure it still
fits in 80 columns.
---
lib/PublicInbox/View.pm | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 0de53cb..65d7d01 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -576,26 +576,27 @@ sub thread_skel {
my $mid = mid_clean($hdr->header_raw('Message-ID'));
my $sres = $srch->get_thread($mid);
my $nr = $sres->{total};
- my $expand = qq(<a\nhref="${tpfx}T/#u">expand</a> ) .
- qq(/ <a\nhref="${tpfx}t.mbox.gz">mbox.gz</a> ) .
- qq(/ <a\nhref="${tpfx}t.atom">Atom feed</a>);
+ my $expand = qq(expand[<a\nhref="${tpfx}T/#u">flat</a>) .
+ qq(|<a\nhref="${tpfx}t/#u">nested</a>] ) .
+ qq(<a\nhref="${tpfx}t.mbox.gz">mbox.gz</a> ) .
+ qq(<a\nhref="${tpfx}t.atom">Atom feed</a>);
my $parent = in_reply_to($hdr);
$$dst .= "\n<b>Thread overview: </b>";
if ($nr <= 1) {
if (defined $parent) {
- $$dst .= "($expand)\n ";
+ $$dst .= "$expand\n ";
$$dst .= ghost_parent("$tpfx../", $parent) . "\n";
} else {
- $$dst .= "[no followups, yet] ($expand)\n";
+ $$dst .= "[no followups] $expand\n";
}
$ctx->{next_msg} = undef;
$ctx->{parent_msg} = $parent;
return;
}
- $$dst .= "$nr+ messages in thread ($expand";
- $$dst .= qq! / <a\nhref="#b">[top]</a>)\n!;
+ $$dst .= "$nr+ messages / $expand";
+ $$dst .= qq! <a\nhref="#b">top</a>\n!;
my $subj = $hdr->header('Subject');
defined $subj or $subj = '';
--
EW
reply other threads:[~2018-02-03 2:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180203025533.26725-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).