user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] hold lock while extracting
@ 2017-11-29  1:52 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2017-11-29  1:52 UTC (permalink / raw)
  To: meta

We must not allow slow extracts to run concurrently; as it can
result in duplicate messages being "delivered".
---
 script/ssoma | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/script/ssoma b/script/ssoma
index fbb2460..036f6f1 100755
--- a/script/ssoma
+++ b/script/ssoma
@@ -254,11 +254,10 @@ sub do_sync {
 			push @cmd, '-f' if $opts{force};
 			x(@cmd);
 		});
+		foreach my $target (@$targets) {
+			$ex->extract($target, $since);
+		}
 	});
-
-	foreach my $target (@$targets) {
-		$ex->extract($target, $since);
-	}
 }
 
 sub x {
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-11-29  1:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-29  1:52 [PATCH] hold lock while extracting Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).