From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] www: Atom stream respects timezone
Date: Thu, 13 Jul 2017 22:48:06 +0000 [thread overview]
Message-ID: <20170713224806.21752-1-e@80x24.org> (raw)
Oops, we must not discard the timezone when parsing dates
for the Atom stream.
---
lib/PublicInbox/WwwAtomStream.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/WwwAtomStream.pm b/lib/PublicInbox/WwwAtomStream.pm
index 5a10034..b9c7468 100644
--- a/lib/PublicInbox/WwwAtomStream.pm
+++ b/lib/PublicInbox/WwwAtomStream.pm
@@ -7,7 +7,7 @@ use strict;
use warnings;
use POSIX qw(strftime);
-use Date::Parse qw(strptime);
+use Date::Parse qw(str2time);
use Digest::SHA qw(sha1_hex);
use PublicInbox::Address;
use PublicInbox::Hval qw(ascii_html);
@@ -109,8 +109,8 @@ sub feed_entry {
}
my $href = $base . mid_escape($mid) . '/';
my $date = $hdr->header('Date');
- my @t = eval { strptime($date) } if defined $date;
- @t = gmtime(time) unless scalar @t;
+ my $t = eval { str2time($date) } if defined $date;
+ my @t = gmtime(defined $t ? $t : time);
my $updated = feed_updated(@t);
my $title = $hdr->header('Subject');
--
EW
reply other threads:[~2017-07-13 22:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713224806.21752-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).