user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] hval: only perform one substitution when obfuscating
Date: Thu, 29 Jun 2017 00:13:28 +0000	[thread overview]
Message-ID: <20170629001328.3159-1-e@80x24.org> (raw)

Only one substitution character is necessary when obfuscating
email addresses.
---
 lib/PublicInbox/Hval.pm | 2 +-
 t/hval.t                | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Hval.pm b/lib/PublicInbox/Hval.pm
index 8005088..8d36fc2 100644
--- a/lib/PublicInbox/Hval.pm
+++ b/lib/PublicInbox/Hval.pm
@@ -100,7 +100,7 @@ sub obfuscate_addrs ($$) {
 		if ($addrs->{$addr} || ((defined $re && $domain =~ $re))) {
 			$addr;
 		} else {
-			$addr =~ s!([^\.]+)\.!$1&#8226;!g;
+			$addr =~ s!([^\.]+)\.!$1&#8226;!;
 			$addr
 		}
 		/sge;
diff --git a/t/hval.t b/t/hval.t
index dcbd838..a371266 100644
--- a/t/hval.t
+++ b/t/hval.t
@@ -17,6 +17,7 @@ hello@example.comm
 hello@example.com
 meta@public-inbox.org
 test@public-inbox.org
+test@a.b.c.org
 EOF
 
 PublicInbox::Hval::obfuscate_addrs($ibx, $html);
@@ -26,6 +27,7 @@ hello@example&#8226;comm
 hello@example.com
 meta@public-inbox.org
 test@public-inbox&#8226;org
+test@a&#8226;b.c.org
 EOF
 
 is($html, $exp, 'only obfuscated relevant addresses');
-- 
EW


                 reply	other threads:[~2017-06-29  0:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170629001328.3159-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).