From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 3FF252082F;
	Mon, 26 Jun 2017 04:01:09 +0000 (UTC)
Date: Mon, 26 Jun 2017 04:01:09 +0000
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH 3/5] watch: improve fairness during full rescans
Message-ID: <20170626040109.GA32306@whir>
References: <20170626031545.11879-1-e@80x24.org>
 <20170626031545.11879-4-e@80x24.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20170626031545.11879-4-e@80x24.org>
List-Id: <meta.public-inbox.org>

Eric Wong <e@80x24.org> wrote:
>  sub _try_fsn_paths {
> -	my ($self, $paths) = @_;
> -	_try_path($self, $_->{path}) foreach @$paths;
> -	_done_for_now($self);
> +	my ($self, $scan_re, $paths) = @_;
> +	foreach (@$paths) {
> +		my $path = $_->{path};
> +		if ($path =~ $scan_re) {
> +			scan($self, $path);
> +		} else {
> +			_try_path($self, $path);
> +		}
> +	}

That "_done_for_now($self);" call should not have been
eliminated.  Fixed in the version pushed out to public-inbox.git