user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] import: reset :raw mode for commit title (subject)
@ 2017-05-25  2:38 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2017-05-25  2:38 UTC (permalink / raw)
  To: meta

This was necessary for the presence of the 0xa0 byte(*)
in the Subject: of the message at:
http://blade.nagaokaut.ac.jp/ruby/ruby-core/3220

(*) That is 0xa0, not 0x0a ("\n"), so I wonder if the
    nibbles got swapped somehow.
---
 lib/PublicInbox/Import.pm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index 13671a4..65da4dd 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -191,11 +191,10 @@ sub add {
 	binmode $w, ':utf8' or die "binmode :utf8 failed: $!";
 	print $w "commit $ref\nmark :$commit\n",
 		"author $name <$email> $date\n",
-		"committer $self->{ident} ", now2822(), "\n",
-		"data ", (bytes::length($subject) + 1), "\n",
-		$subject, "\n\n" or wfail;
+		"committer $self->{ident} ", now2822(), "\n" or wfail;
 	binmode $w, ':raw' or die "binmode :raw failed: $!";
-
+	print $w "data ", (bytes::length($subject) + 1), "\n",
+		$subject, "\n\n" or wfail;
 	if ($tip ne '') {
 		print $w 'from ', ($parent ? $parent : $tip), "\n" or wfail;
 	}
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-05-25  2:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-25  2:38 [PATCH] import: reset :raw mode for commit title (subject) Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).