user/dev discussion of public-inbox itself
 help / Atom feed
* [PATCH ssoma] extractor: do not needlessly update config file
  2017-03-21 21:15 [PATCH ssoma] extractor: backup state file when updating and fsync Eric Wong
@ 2017-03-21 22:50 ` Eric Wong
  0 siblings, 0 replies; 1+ messages in thread
From: Eric Wong @ 2017-03-21 22:50 UTC (permalink / raw)
  To: meta

No reason to trigger excessive writes when nothing is done.
---
 lib/Ssoma/Extractor.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/Ssoma/Extractor.pm b/lib/Ssoma/Extractor.pm
index 7e2b5d1..baf9adb 100644
--- a/lib/Ssoma/Extractor.pm
+++ b/lib/Ssoma/Extractor.pm
@@ -47,6 +47,7 @@ sub _extract {
 
 	my $lkey = "target.$target.last-imported";
 	my $last = $cfg->{$lkey};
+	my $last_imported = $last;
 
 	my $ref = $self->{ref};
 	my $tip = $git->qx_sha1("git rev-parse $ref^0");
@@ -106,7 +107,7 @@ sub _extract {
 	}
 
 	# update the last-imported var
-	{
+	if (!defined($last_imported) || $last_imported ne $tip) {
 		# This state file is important, and git does not fsync it.
 		if (open my $st, '<', $state) {
 			# clobber existing backup
-- 
EW


^ permalink raw reply	[flat|nested] 1+ messages in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-21 21:15 [PATCH ssoma] extractor: backup state file when updating and fsync Eric Wong
2017-03-21 22:50 ` [PATCH ssoma] extractor: do not needlessly update config file Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox