user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH ssoma] extractor: backup state file when updating and fsync
Date: Tue, 21 Mar 2017 21:15:29 +0000	[thread overview]
Message-ID: <20170321211529.6957-1-e@80x24.org> (raw)

The state file is important, so try not to lose it by
creating a backup before git writes it, and fsync the
result ASAP since git does not consider the config file
important enough.
---
 lib/Ssoma/Extractor.pm | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/lib/Ssoma/Extractor.pm b/lib/Ssoma/Extractor.pm
index afc9afd..7e2b5d1 100644
--- a/lib/Ssoma/Extractor.pm
+++ b/lib/Ssoma/Extractor.pm
@@ -7,6 +7,7 @@ use strict;
 use warnings;
 use Ssoma::Git;
 use Email::LocalDelivery;
+use IO::File;
 
 sub new {
 	my ($class, $git) = @_;
@@ -106,9 +107,32 @@ sub _extract {
 
 	# update the last-imported var
 	{
+		# This state file is important, and git does not fsync it.
+		if (open my $st, '<', $state) {
+			# clobber existing backup
+			my $bak = "$state.bak";
+			open my $bk, '>', $bak or die
+				"failed to open backup ($bak): $!";
+			my $size = -s $st;
+			my $r = read($st, my $buf, $size);
+			$st->close or die "close $state failed for copy: $!";
+			defined $r or die "failed read $size from $state: $!";
+			$r == $size or die "read ($r != $size) from $state";
+			$bk->write($buf) or die "failed to write $bak: $!";
+			defined($bk->flush) or die "flush $bak failed: $!";
+			defined($bk->sync) or die "fsync $bak failed: $!";
+			$bk->close or die "close $bak failed: $!";
+		}
+
 		local $ENV{GIT_CONFIG} = $state;
 		my $rv = system(qw/git config/, $lkey, $tip);
-		$rv == 0 or die "git config $lkey $tip failed: $? ($rv)\n";
+		$rv == 0 or die "git config $lkey $tip failed: $? ($rv)";
+
+		# git-config(1) does not fsync state files by default
+		open my $st, '+<', $state or
+				die "failed to open state ($state): $!";
+		defined($st->sync) or die "fsync $state failed: $!";
+		$st->close or die "close $state failed for fsync: $!";
 	}
 }
 
-- 
EW


             reply	other threads:[~2017-03-21 21:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21 21:15 Eric Wong [this message]
2017-03-21 22:50 ` [PATCH ssoma] extractor: do not needlessly update config file Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170321211529.6957-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).