From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/2] searchmsg: do not memoize {date} field
Date: Sat, 17 Dec 2016 11:53:24 +0000 [thread overview]
Message-ID: <20161217115324.27937-3-e@80x24.org> (raw)
In-Reply-To: <20161217115324.27937-1-e@80x24.org>
We only generate the ->date once in NNTP, so creating
the hash entry is a waste.
---
lib/PublicInbox/SearchMsg.pm | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/PublicInbox/SearchMsg.pm b/lib/PublicInbox/SearchMsg.pm
index 57fec16..9f3e27f 100644
--- a/lib/PublicInbox/SearchMsg.pm
+++ b/lib/PublicInbox/SearchMsg.pm
@@ -77,13 +77,10 @@ my @MoY = qw(Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec);
sub date ($) {
my ($self) = @_;
- my $date = __hdr($self, 'date');
- return $date if defined $date;
my $ts = $self->{ts};
return unless defined $ts;
my ($sec, $min, $hour, $mday, $mon, $year, $wday) = gmtime($ts);
- $self->{date} = "$DoW[$wday], ".
- sprintf("%02d $MoY[$mon] %04d %02d:%02d:%02d +0000",
+ "$DoW[$wday], " . sprintf("%02d $MoY[$mon] %04d %02d:%02d:%02d +0000",
$mday, $year+1900, $hour, $min, $sec);
}
--
EW
prev parent reply other threads:[~2016-12-17 11:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-17 11:53 [PATCH 0/2] searchmsg: ->date correctness Eric Wong
2016-12-17 11:53 ` [PATCH 1/2] searchmsg: remove locale-dependency for ->date Eric Wong
2016-12-17 11:53 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161217115324.27937-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).