* [PATCH] import: failed GC runs are non-fatal
@ 2016-10-16 0:38 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-10-16 0:38 UTC (permalink / raw)
To: meta
We should not completely kill a process if "git gc --auto"
errors out due to a warning or whatnot.
---
lib/PublicInbox/Import.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index 611f7b1..1ac112b 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -240,7 +240,8 @@ sub done {
my $s = PublicInbox::SearchIdx->new($inbox);
$s->index_sync({ ref => $self->{ref} });
};
- run_die([@cmd, qw(gc --auto)], undef);
+
+ eval { run_die([@cmd, qw(gc --auto)], undef) };
}
my $lockfh = delete $self->{lockfh} or die "BUG: not locked: $!";
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-10-16 0:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-16 0:38 [PATCH] import: failed GC runs are non-fatal Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).