From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 1C52E209B8 for ; Wed, 5 Oct 2016 23:57:26 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 05/17] inbox: deal with ghost smsg Date: Wed, 5 Oct 2016 23:57:10 +0000 Message-Id: <20161005235722.14857-6-e@80x24.org> In-Reply-To: <20161005235722.14857-1-e@80x24.org> References: <20161005235722.14857-1-e@80x24.org> List-Id: smsg will be undef for ghost messages in a subsequent commit --- lib/PublicInbox/Inbox.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm index 414973c..8c63908 100644 --- a/lib/PublicInbox/Inbox.pm +++ b/lib/PublicInbox/Inbox.pm @@ -211,6 +211,8 @@ sub msg_by_path ($$;$) { sub msg_by_smsg ($$;$) { my ($self, $smsg, $ref) = @_; + return unless defined $smsg; # ghost + # backwards compat to fallback to msg_by_mid # TODO: remove if we bump SCHEMA_VERSION in Search.pm: defined(my $blob = $smsg->blob) or return msg_by_mid($self, $smsg->mid); -- EW