From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 08/10] search: avoid mindlessly calling body_set
Date: Fri, 9 Sep 2016 00:01:29 +0000 [thread overview]
Message-ID: <20160909000131.18584-9-e@80x24.org> (raw)
In-Reply-To: <20160909000131.18584-1-e@80x24.org>
It's not worth entering a complex codepath in Email::MIME to
save some (probably immeasurable amount of) memory, here. We've
already stopped doing this in our WWW code a while back, too.
If we really cared enough about it, we'd prioritize work on a
streaming replacement for Email::MIME.
---
lib/PublicInbox/SearchIdx.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index 86be9ed..0e2d225 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -188,7 +188,6 @@ sub add_message {
my (@orig, @quot);
my $body = $part->body;
- $part->body_set('');
my @lines = split(/\n/, $body);
while (defined(my $l = shift @lines)) {
if ($l =~ /^>/) {
--
EW
next prev parent reply other threads:[~2016-09-09 0:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 0:01 [PATCH 0/10] search: more mairix prefix compatibility Eric Wong
2016-09-09 0:01 ` [PATCH 01/10] search: allow searching user fields (To/Cc/From) Eric Wong
2016-09-09 0:01 ` [PATCH 02/10] search: drop longer subject: prefix for search Eric Wong
2016-09-09 0:01 ` [PATCH 03/10] search: more granular message body searching Eric Wong
2016-09-09 0:01 ` [PATCH 04/10] search: fix space regressions from recent changes Eric Wong
2016-09-09 0:01 ` [PATCH 05/10] search: match quote detection behavior of view Eric Wong
2016-09-09 0:01 ` [PATCH 06/10] search: increase term positions for each quoted hunk Eric Wong
2016-09-09 0:01 ` [PATCH 07/10] search: fix compatibility with Debian wheezy Eric Wong
2016-09-09 0:01 ` Eric Wong [this message]
2016-09-09 0:01 ` [PATCH 09/10] search: match the behavior of WWW for indexing text Eric Wong
2016-09-09 0:01 ` [PATCH 10/10] search: index attachment filenames Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909000131.18584-9-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).