user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] newswww: include body text in 404 response
@ 2016-08-14 10:21 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-08-14 10:21 UTC (permalink / raw)
  To: meta

Some browsers do not give any indication of the HTTP error
code on errors, so show the error text to the user like we
do in the top-level WWW module.
---
 lib/PublicInbox/NewsWWW.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/NewsWWW.pm b/lib/PublicInbox/NewsWWW.pm
index 908c435..9b01dcd 100644
--- a/lib/PublicInbox/NewsWWW.pm
+++ b/lib/PublicInbox/NewsWWW.pm
@@ -43,7 +43,7 @@ sub call {
 
 		return [ $code, $h, [ "Redirecting to $url\n" ] ]
 	}
-	[ 404, [ 'Content-Type' => 'text/plain' ], [] ];
+	[ 404, [ 'Content-Type' => 'text/plain' ], [ "404 Not Found\n" ] ];
 }
 
 1;
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-14 10:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-14 10:21 [PATCH] newswww: include body text in 404 response Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).