user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] mda: fix address matching in address lists
Date: Tue, 26 Jul 2016 00:36:32 +0000	[thread overview]
Message-ID: <20160726003632.3745-1-e@80x24.org> (raw)

This is common when multiple participants are in a thread.
---
 lib/PublicInbox/MDA.pm |  2 +-
 t/precheck.t           | 17 +++++++++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/MDA.pm b/lib/PublicInbox/MDA.pm
index 0f583e6..bcf5358 100644
--- a/lib/PublicInbox/MDA.pm
+++ b/lib/PublicInbox/MDA.pm
@@ -64,7 +64,7 @@ sub alias_specified {
 	} @address;
 
 	foreach my $line ($simple->header('Cc'), $simple->header('To')) {
-		my @addrs = ($line =~ /([^<\s]+\@[^>\s]+)/g);
+		my @addrs = ($line =~ /([^,<\s]+\@[^,>\s]+)/g);
 		foreach my $addr (@addrs) {
 			if ($ok{lc(__drop_plus($addr))}) {
 				return 1;
diff --git a/t/precheck.t b/t/precheck.t
index 6c353d8..0c3ce1c 100644
--- a/t/precheck.t
+++ b/t/precheck.t
@@ -27,6 +27,23 @@ sub do_checks {
 }
 
 {
+	my $s = Email::Simple->create(
+		header => [
+			From => 'abc@example.com',
+			To => 'abc@example.com',
+			Cc => 'c@example.com, another-list@example.com',
+			'Content-Type' => 'text/plain',
+			Subject => 'list is fine',
+			'Message-ID' => '<MID@host>',
+			Date => 'Wed, 09 Apr 2014 01:28:34 +0000',
+		],
+		body => "hello world\n",
+	);
+	my $addr = [ 'c@example.com', 'd@example.com' ];
+	ok(PublicInbox::MDA->precheck($s, $addr), 'Cc list is OK');
+}
+
+{
 	do_checks(Email::Simple->create(
 		header => [
 			From => 'a@example.com',
-- 
EW


                 reply	other threads:[~2016-07-26  0:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160726003632.3745-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).