From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id D699B2070F for ; Wed, 6 Jul 2016 07:14:37 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 03/10] hval: get rid of unused parameter for new_msgid Date: Wed, 6 Jul 2016 07:14:28 +0000 Message-Id: <20160706071435.18143-4-e@80x24.org> In-Reply-To: <20160706071435.18143-1-e@80x24.org> References: <20160706071435.18143-1-e@80x24.org> List-Id: Exposing compressed Message-IDs in URLs was a mistake, remove a remnant of it. --- lib/PublicInbox/ExtMsg.pm | 2 +- lib/PublicInbox/Hval.pm | 2 +- lib/PublicInbox/View.pm | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/PublicInbox/ExtMsg.pm b/lib/PublicInbox/ExtMsg.pm index 73bd4b1..62381e9 100644 --- a/lib/PublicInbox/ExtMsg.pm +++ b/lib/PublicInbox/ExtMsg.pm @@ -99,7 +99,7 @@ again: } my $code = 404; - my $h = PublicInbox::Hval->new_msgid($mid, 1); + my $h = PublicInbox::Hval->new_msgid($mid); my $href = $h->as_href; my $html = $h->as_html; my $title = "Message-ID <$html> not found"; diff --git a/lib/PublicInbox/Hval.pm b/lib/PublicInbox/Hval.pm index 9ba7809..652aef3 100644 --- a/lib/PublicInbox/Hval.pm +++ b/lib/PublicInbox/Hval.pm @@ -31,7 +31,7 @@ sub new { } sub new_msgid { - my ($class, $msgid, $no_compress) = @_; + my ($class, $msgid) = @_; $msgid = mid_clean($msgid); $class->new($msgid, $msgid); } diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index e8395ae..dc6096f 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -551,7 +551,7 @@ sub _parent_headers { my $irt = in_reply_to($hdr); if (defined $irt) { - my $v = PublicInbox::Hval->new_msgid($irt, 1); + my $v = PublicInbox::Hval->new_msgid($irt); my $html = $v->as_html; my $href = $v->as_href; $rv .= "In-Reply-To: <"; @@ -661,7 +661,7 @@ sub html_footer { } sub linkify_ref_nosrch { - my $v = PublicInbox::Hval->new_msgid($_[0], 1); + my $v = PublicInbox::Hval->new_msgid($_[0]); my $html = $v->as_html; my $href = $v->as_href; "<$html>"; -- EW