From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 03/10] hval: get rid of unused parameter for new_msgid
Date: Wed, 6 Jul 2016 07:14:28 +0000 [thread overview]
Message-ID: <20160706071435.18143-4-e@80x24.org> (raw)
In-Reply-To: <20160706071435.18143-1-e@80x24.org>
Exposing compressed Message-IDs in URLs was a mistake,
remove a remnant of it.
---
lib/PublicInbox/ExtMsg.pm | 2 +-
lib/PublicInbox/Hval.pm | 2 +-
lib/PublicInbox/View.pm | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/ExtMsg.pm b/lib/PublicInbox/ExtMsg.pm
index 73bd4b1..62381e9 100644
--- a/lib/PublicInbox/ExtMsg.pm
+++ b/lib/PublicInbox/ExtMsg.pm
@@ -99,7 +99,7 @@ again:
}
my $code = 404;
- my $h = PublicInbox::Hval->new_msgid($mid, 1);
+ my $h = PublicInbox::Hval->new_msgid($mid);
my $href = $h->as_href;
my $html = $h->as_html;
my $title = "Message-ID <$html> not found";
diff --git a/lib/PublicInbox/Hval.pm b/lib/PublicInbox/Hval.pm
index 9ba7809..652aef3 100644
--- a/lib/PublicInbox/Hval.pm
+++ b/lib/PublicInbox/Hval.pm
@@ -31,7 +31,7 @@ sub new {
}
sub new_msgid {
- my ($class, $msgid, $no_compress) = @_;
+ my ($class, $msgid) = @_;
$msgid = mid_clean($msgid);
$class->new($msgid, $msgid);
}
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index e8395ae..dc6096f 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -551,7 +551,7 @@ sub _parent_headers {
my $irt = in_reply_to($hdr);
if (defined $irt) {
- my $v = PublicInbox::Hval->new_msgid($irt, 1);
+ my $v = PublicInbox::Hval->new_msgid($irt);
my $html = $v->as_html;
my $href = $v->as_href;
$rv .= "In-Reply-To: <";
@@ -661,7 +661,7 @@ sub html_footer {
}
sub linkify_ref_nosrch {
- my $v = PublicInbox::Hval->new_msgid($_[0], 1);
+ my $v = PublicInbox::Hval->new_msgid($_[0]);
my $html = $v->as_html;
my $href = $v->as_href;
"<<a\nhref=\"../$href/\">$html</a>>";
--
EW
next prev parent reply other threads:[~2016-07-06 7:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 7:14 [PATCH 0/10] various misc fixes and updates Eric Wong
2016-07-06 7:14 ` [PATCH 01/10] scripts/dc-dlvr: ensure temporary files are removed Eric Wong
2016-07-06 7:14 ` [PATCH 02/10] daemon: disable USR2/TTIN/TTOU/WINCH in workers Eric Wong
2016-07-06 7:14 ` Eric Wong [this message]
2016-07-06 7:14 ` [PATCH 04/10] address: attempt to handle comments somewhat Eric Wong
2016-07-06 7:14 ` [PATCH 05/10] wwwstream: allow undef noop callback Eric Wong
2016-07-06 7:14 ` [PATCH 06/10] extmsg: disable automatic inbox switching Eric Wong
2016-07-06 7:14 ` [PATCH 07/10] extmsg: switch to wwwstream for partial match, too Eric Wong
2016-07-06 7:14 ` [PATCH 08/10] view: fix double-escaping of ghost links Eric Wong
2016-07-06 7:14 ` [PATCH 09/10] www: use HTML <hr> instead of XHTML <hr /> Eric Wong
2016-07-06 7:14 ` [PATCH 10/10] feed: fix links to attachments in Atom feed Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706071435.18143-4-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).