user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] view: move per-message anchor to top in conversation view
@ 2016-06-30 18:53 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-06-30 18:53 UTC (permalink / raw)
  To: meta

This fixes the '^' (up) link in the $INBOX/new.html endpoint
for search-less displays.
---
 lib/PublicInbox/View.pm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 8487c2a..11d8dd5 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -125,9 +125,10 @@ sub index_entry {
 	my $root_anchor = $ctx->{root_anchor} || '';
 	my $irt = in_reply_to($hdr);
 
-	my $rv = '<b>'.ascii_html($subj).'</b>';
-	$rv = "<u\nid=u>$rv</u>" if $root_anchor eq $id_m;
-	$rv .= "\n";
+	my $rv = "<a\nhref=#e$id\nid=m$id>*</a> ";
+	$subj = '<b>'.ascii_html($subj).'</b>';
+	$subj = "<u\nid=u>$subj</u>" if $root_anchor eq $id_m;
+	$rv .= $subj . "\n";
 	$rv .= _th_index_lite($mid_raw, $irt, $id, $ctx);
 	my @tocc;
 	foreach my $f (qw(To Cc)) {
@@ -241,8 +242,7 @@ sub _th_index_lite {
 			$rv .= $pad . $mapping->{$nn->messageid}->[1];
 		}
 	}
-	$rv .= "<a\nhref=#e$id\nid=m$id>_</a> ";
-	$rv .= "<a\nhref=#r$id>$s_s, $s_c; $ctx->{s_nr}</a>\n";
+	$rv .= $pad ."<a\nhref=#r$id>$s_s, $s_c; $ctx->{s_nr}</a>\n";
 }
 
 sub walk_thread {
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-06-30 18:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-30 18:53 [PATCH] view: move per-message anchor to top in conversation view Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).