From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] www_stream: linkify cloneurl entries if they're HTTP/HTTPS
Date: Sat, 25 Jun 2016 22:23:47 +0000 [thread overview]
Message-ID: <20160625222347.13663-1-e@80x24.org> (raw)
They may be other public-inbox instances which are browseable,
so provide a link to them to encourage their use as clones.
---
lib/PublicInbox/WwwStream.pm | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/WwwStream.pm b/lib/PublicInbox/WwwStream.pm
index 62a4fe2..34f32c0 100644
--- a/lib/PublicInbox/WwwStream.pm
+++ b/lib/PublicInbox/WwwStream.pm
@@ -44,8 +44,6 @@ sub _html_end {
my $ctx = $self->{ctx};
my $obj = $ctx->{-inbox};
my $desc = ascii_html($obj->description);
- my @urls = @{$obj->cloneurl};
- my %seen = map { $_ => 1 } @urls;
# FIXME: cleanup
my $env = $ctx->{env};
@@ -54,9 +52,15 @@ sub _html_end {
"$env->{SERVER_NAME}:$env->{SERVER_PORT}";
my $http = "$scheme://$host_port".($env->{SCRIPT_NAME} || '/');
$http = URI->new($http . $obj->{name})->canonical->as_string;
- $seen{$http} or unshift @urls, $http;
+ my %seen = ( $http => 1 );
+ my @urls = ($http);
+ foreach my $u (@{$obj->cloneurl}) {
+ next if $seen{$u};
+ $seen{$u} = 1;
+ push @urls, $u =~ /\Ahttps?:/ ? qq(<a\nhref="$u">$u</a>) : $u;
+ }
if (scalar(@urls) == 1) {
- $urls .= " git clone --mirror $urls[0]";
+ $urls .= " git clone --mirror $http";
} else {
$urls .= "\n" .
join("\n", map { "\tgit clone --mirror $_" } @urls);
--
EW
reply other threads:[~2016-06-25 22:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160625222347.13663-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).