user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/2] search: support Subject:-less messages
Date: Tue, 21 Jun 2016 10:35:36 +0000	[thread overview]
Message-ID: <20160621103537.10422-2-e@80x24.org> (raw)
In-Reply-To: <20160621103537.10422-1-e@80x24.org>

Some mailing lists allow empty Subject headers and we shall support
searching and indexing them.
---
 lib/PublicInbox/Search.pm | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index bf50365..3a908ac 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -107,12 +107,15 @@ sub get_thread {
 
 	return { total => 0, msgs => [] } unless $smsg;
 	my $qtid = Search::Xapian::Query->new(xpfx('thread').$smsg->thread_id);
-	my $path = id_compress($smsg->path);
-	my $qsub = Search::Xapian::Query->new(xpfx('path').$path);
-	my $query = Search::Xapian::Query->new(OP_OR, $qtid, $qsub);
+	my $path = $smsg->path;
+	if (defined $path && $path ne '') {
+		my $path = id_compress($smsg->path);
+		my $qsub = Search::Xapian::Query->new(xpfx('path').$path);
+		$qtid = Search::Xapian::Query->new(OP_OR, $qtid, $qsub);
+	}
 	$opts ||= {};
 	$opts->{limit} ||= 1000;
-	_do_enquire($self, $query, $opts);
+	_do_enquire($self, $qtid, $opts);
 }
 
 sub _do_enquire {

  reply	other threads:[~2016-06-21 10:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 10:35 [PATCH 0/2] Subject-less message support Eric Wong
2016-06-21 10:35 ` Eric Wong [this message]
2016-06-21 10:35 ` [PATCH 2/2] view: support non-existent Subjects for permalink titles Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160621103537.10422-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).