user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] unsubscribe: fix off-by-one error
Date: Tue, 7 Jun 2016 13:40:44 +0000	[thread overview]
Message-ID: <20160607134044.GA19192@dcvr.yhbt.net> (raw)
In-Reply-To: <20160607131821.GA6966@dcvr.yhbt.net>

Oops, pesky users of single-character email addresses!
---
 lib/PublicInbox/Unsubscribe.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Unsubscribe.pm b/lib/PublicInbox/Unsubscribe.pm
index 97ff97f..95348ea 100644
--- a/lib/PublicInbox/Unsubscribe.pm
+++ b/lib/PublicInbox/Unsubscribe.pm
@@ -77,7 +77,7 @@ sub _user_list_addr {
 			'Missing mailing list name in path component');
 	}
 	my $user = eval { $self->{cipher}->decrypt(decode_base64url($u)) };
-	if (!defined $user || index($user, '@') <= 1) {
+	if (!defined $user || index($user, '@') < 1) {
 		my $err = quotemeta($@);
 		my $errors = $env->{'psgi.errors'};
 		$errors->print("error decrypting: $u\n");

      parent reply	other threads:[~2016-06-07 13:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-20 21:36 [PATCH] unsubscribe: get off mah lawn^H^H^Hist Eric Wong
2016-05-21  4:24 ` [PATCH 2/3] unsubscribe: bad URL fixup Eric Wong
2016-05-21  4:24 ` [PATCH 3/3] examples/unsubscribe-psgi@.service: disable worker processes Eric Wong
2016-05-27  8:08 ` [PATCH] unsubscribe.milter: use default postfork dispatcher Eric Wong
2016-06-07 13:18 ` Merge branch 'unsubscribe' Eric Wong
2016-06-07 13:20   ` [PATCH] unsubscribe.psgi: disable confirmation Eric Wong
2016-06-07 13:21   ` [PATCH] unsubscribe.milter: implement archive blacklist Eric Wong
2016-06-07 13:40   ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160607134044.GA19192@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).