user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/2] inbox: drop references ASAP for search and msgmap
Date: Sun, 29 May 2016 04:16:43 +0000	[thread overview]
Message-ID: <20160529041644.345-2-e@80x24.org> (raw)
In-Reply-To: <20160529041644.345-1-e@80x24.org>

We can't leave them lingering in the parent process at
all due to the risk of corruption with multiple processes.
---
 lib/PublicInbox/Inbox.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index d050dc8..27218de 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -86,7 +86,7 @@ sub base_url {
 sub nntp_usable {
 	my ($self) = @_;
 	my $ret = $self->mm && $self->search;
-	weaken_all();
+	$self->{mm} = $self->{search} = undef;
 	$ret;
 }
 

  reply	other threads:[~2016-05-29  4:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-29  4:16 [PATCH 0/2] nntp fixes Eric Wong
2016-05-29  4:16 ` Eric Wong [this message]
2016-05-29  4:16 ` [PATCH 2/2] nntp: fix for missing articles/bodies/heads Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160529041644.345-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).